From bec3907082a7f952c34b5565e229731708d713d0 Mon Sep 17 00:00:00 2001 From: Mark Delk Date: Thu, 17 Oct 2024 11:27:47 -0500 Subject: [PATCH 1/2] add a clarification comment --- .github/workflows/test-yjit.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test-yjit.yaml b/.github/workflows/test-yjit.yaml index bf934c5fdc1..5ed5089f4bf 100644 --- a/.github/workflows/test-yjit.yaml +++ b/.github/workflows/test-yjit.yaml @@ -15,6 +15,10 @@ jobs: - '--yjit' - '--yjit --yjit-stats=quiet' exclude: + # NOTE: `--yjit-stats=quiet` is only present in 3.3+. + # We've had `--yjit-stats` since 3.0, but + # 1) it dumps stat info to stdout, and + # 2) non of our <3.3 tests require the additional stats - ruby: '3.2' rubyopt: '--yjit --yjit-stats=quiet' name: Test YJIT (${{ matrix.os }}, ${{ matrix.ruby }} ${{ matrix.rubyopt }}) From d403350ef872787180e16be5fb34c1ea40cdfe3c Mon Sep 17 00:00:00 2001 From: Mark Delk Date: Thu, 17 Oct 2024 17:02:14 -0500 Subject: [PATCH 2/2] fix typo --- .github/workflows/test-yjit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-yjit.yaml b/.github/workflows/test-yjit.yaml index 5ed5089f4bf..b9ce09fbda3 100644 --- a/.github/workflows/test-yjit.yaml +++ b/.github/workflows/test-yjit.yaml @@ -18,7 +18,7 @@ jobs: # NOTE: `--yjit-stats=quiet` is only present in 3.3+. # We've had `--yjit-stats` since 3.0, but # 1) it dumps stat info to stdout, and - # 2) non of our <3.3 tests require the additional stats + # 2) none of our <3.3 tests require the additional stats - ruby: '3.2' rubyopt: '--yjit --yjit-stats=quiet' name: Test YJIT (${{ matrix.os }}, ${{ matrix.ruby }} ${{ matrix.rubyopt }})