Return GENERAL error_code instead of PROVIDER_FATAL by default

Author: dd-oleksii

lib/datadog/open_feature/evaluation_engine.rb

@@ -39,7 +39,7 @@ def fetch_value(flag_key:, default_value:, expected_type:, evaluation_context: n
         @telemetry.report(e, description: 'OpenFeature: Failed to fetch flag value')
 
         ResolutionDetails.build_error(
-          value: default_value, error_code: Ext::PROVIDER_FATAL, error_message: e.message
+          value: default_value, error_code: Ext::GENERAL, error_message: e.message
         )
       end
 

lib/datadog/open_feature/ext.rb

@@ -6,6 +6,7 @@ module Ext
       ERROR = 'ERROR'
       INITIALIZING = 'INITIALIZING'
       UNKNOWN_TYPE = 'UNKNOWN_TYPE'
+      GENERAL = 'GENERAL'
       PROVIDER_FATAL = 'PROVIDER_FATAL'
       PROVIDER_NOT_READY = 'PROVIDER_NOT_READY'
     end

lib/datadog/open_feature/provider.rb

@@ -122,7 +122,7 @@ def evaluate(flag_key, default_value:, expected_type:, evaluation_context:)
       rescue => e
         ::OpenFeature::SDK::Provider::ResolutionDetails.new(
           value: default_value,
-          error_code: Ext::PROVIDER_FATAL,
+          error_code: Ext::GENERAL,
           error_message: e.message,
           reason: Ext::ERROR
         )

sig/datadog/open_feature/ext.rbs

@@ -7,6 +7,8 @@ module Datadog
 
       UNKNOWN_TYPE: ::String
 
+      UNKNOWN ::String
+
       PROVIDER_FATAL: ::String
 
       PROVIDER_NOT_READY: ::String

spec/datadog/open_feature/evaluation_engine_spec.rb

@@ -96,7 +96,7 @@
         expect(reporter).not_to receive(:report)
 
         expect(result.value).to eq('fallback')
-        expect(result.error_code).to eq('PROVIDER_FATAL')
+        expect(result.error_code).to eq('GENERAL')
         expect(result.error_message).to eq('Crash')
         expect(result.reason).to eq('ERROR')
       end