Skip to content

Commit 3b8bf6c

Browse files
committed
wip
1 parent 9d3f807 commit 3b8bf6c

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

Diff for: Steepfile

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ target :datadog do
6767
ignore 'lib/datadog/core/environment/socket.rb'
6868
ignore 'lib/datadog/core/environment/variable_helpers.rb'
6969
ignore 'lib/datadog/core/environment/vm_cache.rb'
70+
ignore 'lib/datadog/core/error.rb'
7071
ignore 'lib/datadog/core/metrics/client.rb'
7172
ignore 'lib/datadog/core/metrics/helpers.rb'
7273
ignore 'lib/datadog/core/metrics/metric.rb'

Diff for: lib/datadog/core/error.rb

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,10 @@ class << self
1212
def build_from(value)
1313
case value
1414
when Error then value
15-
# steep:ignore:start
1615
when Array then new(*value)
17-
# steep:ignore:end
1816
when Exception then new(value.class, value.message, full_backtrace(value))
19-
when String then new(nil, value)
2017
when ContainsMessage then new(value.class, value.message)
18+
when String then new(nil, value)
2119
else BlankError
2220
end
2321
end
@@ -77,7 +75,7 @@ def backtrace_for(ex, backtrace)
7775
if trace[1]
7876
# Ident stack trace for caller lines, to separate
7977
# them from the main error lines.
80-
trace[1..-1]&.each do |line|
78+
trace[1..-1].each do |line|
8179
backtrace << "\n\tfrom "
8280
backtrace << line
8381
end

Diff for: sig/datadog/core/error.rbs

+10-14
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,25 @@
11
module Datadog
22
module Core
33
class Error
4-
attr_reader type: String
4+
attr_reader type: untyped
55

6-
attr_reader message: String
6+
attr_reader message: untyped
77

8-
attr_reader backtrace: String
8+
attr_reader backtrace: untyped
99

10-
interface _ContainsMessage
11-
def message: () -> String
12-
def class: () -> Class
13-
end
14-
15-
def self.build_from: ((Error | Array[untyped] | ::Exception | _ContainsMessage | ::String) value) -> Error
10+
def self.build_from: (untyped value) -> untyped
1611

1712
private
18-
def self.full_backtrace: (Exception ex) -> String
19-
def self.backtrace_for: (Exception ex, String backtrace) -> void
13+
def self.full_backtrace: (untyped ex) -> untyped
14+
def self.backtrace_for: (untyped ex, untyped backtrace) -> (nil | untyped)
2015

2116
public
2217

23-
def initialize: (?Object? `type`, ?Object? message, ?Object? backtrace) -> void
18+
def initialize: (?untyped? `type`, ?untyped? message, ?untyped? backtrace) -> void
19+
20+
BlankError: untyped
2421

25-
BlankError: Error
26-
ContainsMessage: ^(Object) -> bool
22+
ContainsMessage: untyped
2723
end
2824
end
2925
end

0 commit comments

Comments
 (0)