Gate behind flag

Author: gyuheon0h

.gitignore

@@ -57,5 +57,3 @@ lib/*.so
 
 # Benchmark result files
 /benchmarks/*.json
-
-debug_runtime_callback.rb

lib/datadog/core/configuration/supported_configurations.rb

@@ -32,6 +32,7 @@ module Configuration
          "DD_APPSEC_TRACE_RATE_LIMIT" => {version: ["A"]},
          "DD_APPSEC_WAF_DEBUG" => {version: ["A"]},
          "DD_APPSEC_WAF_TIMEOUT" => {version: ["A"]},
+         "DD_CRASHTRACKER_EMIT_RUNTIME_STACKS" => {version: ["A"]},
          "DD_CRASHTRACKING_ENABLED" => {version: ["A"]},
          "DD_DATA_STREAMS_ENABLED" => {version: ["A"]},
          "DD_DBM_PROPAGATION_MODE" => {version: ["A"]},

lib/datadog/core/crashtracking/component.rb

@@ -57,7 +57,9 @@ def start
           Utils::AtForkMonkeyPatch.apply!
 
           start_or_update_on_fork(action: :start, tags: tags)
-          register_runtime_stack_callback
+          if DATADOG_ENV['DD_CRASHTRACKER_EMIT_RUNTIME_STACKS'] == 'true'
+            register_runtime_stack_callback
+          end
 
           ONLY_ONCE.run do
             Utils::AtForkMonkeyPatch.at_fork(:child) do
@@ -106,7 +108,6 @@ def register_runtime_stack_callback
             return
           end
 
-          # Always use frame-based callback since that's the only type we support
           success = Datadog::RuntimeStacks._native_register_runtime_stack_callback
 
           unless success

spec/datadog/core/crashtracking/component_spec.rb

@@ -1,12 +1,21 @@
 require 'spec_helper'
 require 'datadog/core/crashtracking/component'
+require 'datadog/runtime_stacks'
 
 require 'webrick'
 require 'fiddle'
 
 RSpec.describe Datadog::Core::Crashtracking::Component, skip: !LibdatadogHelpers.supported? do
   let(:logger) { Logger.new($stdout) }
 
+  shared_context 'runtime stack emission enabled' do
+    around do |example|
+      ClimateControl.modify('DD_CRASHTRACKER_EMIT_RUNTIME_STACKS' => 'true') do
+        example.run
+      end
+    end
+  end
+
   describe '.build' do
     let(:settings) { Datadog::Core::Configuration::Settings.new }
     let(:agent_settings) do
@@ -100,6 +109,7 @@
 
   context 'instance methods' do
     describe '#start' do
+      include_context 'runtime stack emission enabled'
       context 'when _native_start_or_update_on_fork raises an exception' do
         it 'logs the exception' do
           crashtracker = build_crashtracker(logger: logger)
@@ -343,6 +353,8 @@
       end
 
       describe 'Ruby and C method runtime stack capture' do
+        include_context 'runtime stack emission enabled'
+
         let(:runtime_stack) { crash_report_experimental[:runtime_stack] }
 
         it 'captures both Ruby and C method frames in mixed stacks' do
@@ -392,6 +404,7 @@ def ruby_method_with_c_calls
             )
           )
 
+          # Sanity check some frames
           expect(frames).to include(
             hash_including(
               function: 'ruby_method_with_c_calls'
@@ -410,6 +423,8 @@ def ruby_method_with_c_calls
     end
 
     describe '#runtime_callback_registered?' do
+      include_context 'runtime stack emission enabled'
+
       it 'returns true when callback is registered' do
         crashtracker = build_crashtracker(logger: logger)
 

supported-configurations.json

@@ -76,6 +76,9 @@
     "DD_APPSEC_WAF_TIMEOUT": {
       "version": ["A"]
     },
+    "DD_CRASHTRACKER_EMIT_RUNTIME_STACKS": {
+      "version": ["A"]
+    },
     "DD_CRASHTRACKING_ENABLED": {
       "version": ["A"]
     },