Skip to content

Commit cb788d7

Browse files
committed
add hardcoded
update workflow file
1 parent d1f47ad commit cb788d7

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

Diff for: .github/scripts/find_gem_version_bounds.rb

+19
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def initialize(directory: 'gemfiles/', contrib_dir: 'lib/datadog/tracing/contrib
2424
def process
2525
parse_gemfiles
2626
process_integrations
27+
include_hardcoded_versions
2728
write_output
2829
end
2930

@@ -111,6 +112,24 @@ def process_integrations
111112
end
112113
end
113114

115+
def include_hardcoded_versions
116+
# `httpx` is maintained externally
117+
@integration_json_mapping['httpx'] = [
118+
'0.11', # Min version Ruby
119+
'0.11', # Max version Ruby
120+
nil, # Min version JRuby
121+
nil # Max version JRuby
122+
]
123+
124+
# `makara` is part of `activerecord`
125+
@integration_json_mapping['makara'] = [
126+
'0.3.5', # Min version Ruby
127+
'0.3.5', # Max version Ruby
128+
nil, # Min version JRuby
129+
nil # Max version JRuby
130+
]
131+
end
132+
114133
def resolve_integration_name(integration)
115134
mod_name = SPECIAL_CASES[integration] || integration.split('_').map(&:capitalize).join
116135
module_name = "Datadog::Tracing::Contrib::#{mod_name}"

Diff for: .github/workflows/generate-supported-versions.yml

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
name: "Generate Supported Versions"
22

33
on:
4-
push:
5-
branches:
6-
- quinna.halim/add-supported-versions-table
74
workflow_dispatch:
85

96

0 commit comments

Comments
 (0)