Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Option to disable incompatible Lograge setup #4268

Open
marcotc opened this issue Jan 8, 2025 · 2 comments
Open

[FEATURE]: Option to disable incompatible Lograge setup #4268

marcotc opened this issue Jan 8, 2025 · 2 comments
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one

Comments

@marcotc
Copy link
Member

marcotc commented Jan 8, 2025

Gem Name

lograge

Gem Version(s)

any

Describe the goal of the feature

In #3839 we added a log message to alert users when an incompatible lograge setup is present.

But because this incompatibility with lograge has been around for quite some time, users have come up with workarounds for it in their code bases.

We should provide an option to disable this log message.

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

@marcotc marcotc added community Was opened by a community member feature-request A request for a new feature or change to an existing one labels Jan 8, 2025
@chrismanderson
Copy link

Something to add to this work - Datadog's docs recommend using lograge for Rails applications. If there's an incompatibility, it should be addressed by changing those docs as well.

See https://www.datadoghq.com/blog/monitoring-rails-with-datadog/#fine-tuning-your-rails-logs

Lograge is a popular library for Rails applications as it converts multi-line request logs to JSON format and provides custom formatting options. You can also use other libraries such as Log4r and Logging to format your application logs, though Lograge is specifically designed for use with Rails applications.

@ivoanjo
Copy link
Member

ivoanjo commented Jan 29, 2025

Ooops, thanks for pointing that out! Will get in touch with the docs team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Projects
None yet
Development

No branches or pull requests

3 participants