-
Notifications
You must be signed in to change notification settings - Fork 399
Add Ruby 4.0 #5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Ruby 4.0 #5084
Conversation
BenchmarksBenchmark execution time: 2025-11-27 17:34:30 Comparing candidate commit d3cc2ad in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - gvl benchmark samples
|
eacf8d5 to
18eace8
Compare
|
Nice! I'm working on the profiling bits, feel free to throw in a disable for those and I'll take care to re-enable them once I have my fixes! |
a6c06b0 to
e9c5e7c
Compare
|
Two fun ones yelling: |
|
Update for profiling: Once these PRs are in
...the profiler should be green on Ruby 4. So skipping profiling specs probably won't be needed on this branch (just need to rebase once the above have landed) |
**What does this PR do?** This PR adds the `ruby-4.0.gemfile` file that's needed for running `bundle install` on Ruby 4.0.0-preview2. The contents of this file being added are copy/pasted from `ruby-4.0.gemfile` with no changes. I did not add or change anything on purpose: This is a very minimal part of the Ruby 4 CI support being prepared in #5084 but unlocks local development with Ruby 4.0. I suggest we keep adjustments/cleanups/etc for that later PR where we officially add Ruby 4.0 to our CI. **Motivation:** Without this file it's impossible to do local development on Ruby 4.0.0-preview2. It also came up in <DataDog/datadog-ruby_core_source#19>: we want to check if the profiler extension compiles on Ruby 4.0 and we're not able without this file. With this PR we can run `bundle install` and start running tests and tackling what's missing. **Additional Notes:** N/A **How to test the change?** Validate that it's possible to run `bundle install` on Ruby 4.0.
90e4d06 to
093af67
Compare
|
Rebased, but we still need a release for DataDog/datadog-ruby_core_source#18 Or we could hack something to temporarily point to git instead. |
I think it's fine to point to git specifically in the |
8ea65c3 to
b613d43
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: d3cc2ad | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
3edbd9c to
e29b181
Compare
This reverts commit 90e4d06.
Hacking/hardcoding on rubygems x bundler x ruby versions produces incorrect results because of mismatched expectations.
This is done separately from `setup-ruby` because the latter has magic that prevents certain installs.
e29b181 to
52b80ab
Compare
What does this PR do?
Add Ruby 4.0 by moving from 3.5 (preview1) to 4.0 (preview2)
Motivation:
Ruby 3.5 isn't going to be a thing! Instead it's going to be 4.0.
Change log entry
None
Additional Notes:
How to test the change?
CI