Skip to content

Commit 09364fe

Browse files
authored
remove mutation_errors and update dashboard (#17195)
1 parent 65aa58e commit 09364fe

File tree

5 files changed

+12
-62
lines changed

5 files changed

+12
-62
lines changed

datadog_cluster_agent/assets/dashboards/datadog_cluster_agent_overview.json

Lines changed: 2 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1393,7 +1393,7 @@
13931393
{
13941394
"data_source": "metrics",
13951395
"name": "query1",
1396-
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{injected:true,$cluster,$namespace} by {mutation_type}"
1396+
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{status:success,$cluster,$namespace} by {mutation_type, injected}"
13971397
}
13981398
],
13991399
"response_format": "timeseries",
@@ -1420,59 +1420,6 @@
14201420
"height": 2
14211421
}
14221422
},
1423-
{
1424-
"id": 4551516642114976,
1425-
"definition": {
1426-
"title": "Mutation errors by type and reason",
1427-
"show_legend": true,
1428-
"legend_layout": "auto",
1429-
"legend_columns": [
1430-
"avg",
1431-
"min",
1432-
"max",
1433-
"value",
1434-
"sum"
1435-
],
1436-
"type": "timeseries",
1437-
"requests": [
1438-
{
1439-
"formulas": [
1440-
{
1441-
"formula": "query1"
1442-
}
1443-
],
1444-
"on_right_yaxis": false,
1445-
"queries": [
1446-
{
1447-
"data_source": "metrics",
1448-
"name": "query1",
1449-
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_errors{$cluster,$namespace} by {mutation_type,reason}"
1450-
}
1451-
],
1452-
"response_format": "timeseries",
1453-
"style": {
1454-
"palette": "dog_classic",
1455-
"line_type": "solid",
1456-
"line_width": "normal"
1457-
},
1458-
"display_type": "area"
1459-
}
1460-
],
1461-
"yaxis": {
1462-
"include_zero": true,
1463-
"scale": "linear",
1464-
"min": "auto",
1465-
"max": "auto"
1466-
},
1467-
"markers": []
1468-
},
1469-
"layout": {
1470-
"x": 8,
1471-
"y": 16,
1472-
"width": 4,
1473-
"height": 2
1474-
}
1475-
},
14761423
{
14771424
"id": 1453748622802082,
14781425
"definition": {
@@ -1583,7 +1530,7 @@
15831530
{
15841531
"data_source": "metrics",
15851532
"name": "query1",
1586-
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{injected:false,$cluster,$namespace} by {mutation_type}"
1533+
"query": "avg:datadog.cluster_agent.admission_webhooks.mutation_attempts{status:error,$cluster,$namespace} by {mutation_type}"
15871534
}
15881535
],
15891536
"response_format": "timeseries",
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
removed `admission_webhooks.mutation_errors` metric in the `datadog_cluster_agent` integration

datadog_cluster_agent/datadog_checks/datadog_cluster_agent/check.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
'admission_webhooks_library_injection_attempts': 'admission_webhooks.library_injection_attempts',
1010
'admission_webhooks_library_injection_errors': 'admission_webhooks.library_injection_errors',
1111
'admission_webhooks_mutation_attempts': 'admission_webhooks.mutation_attempts',
12-
'admission_webhooks_mutation_errors': 'admission_webhooks.mutation_errors',
1312
'admission_webhooks_patcher_attempts': 'admission_webhooks.patcher.attempts',
1413
'admission_webhooks_patcher_completed': 'admission_webhooks.patcher.completed',
1514
'admission_webhooks_patcher_errors': 'admission_webhooks.patcher.errors',

datadog_cluster_agent/tests/fixtures/metrics.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
# HELP admission_webhooks_certificate_expiry Time left before the certificate expires in hours.
22
# TYPE admission_webhooks_certificate_expiry gauge
33
admission_webhooks_certificate_expiry 11.083180892013889
4-
# HELP admission_webhooks_mutation_attempts Number of pod mutation attempts by mutation type (agent config, standard tags).
4+
# HELP admission_webhooks_mutation_attempts Number of pod mutation attempts by mutation type
55
# TYPE admission_webhooks_mutation_attempts gauge
6-
admission_webhooks_mutation_attempts{mutation_type="agent_config"} 100
7-
# HELP admission_webhooks_mutation_errors Number of mutation failures by mutation type (agent config, standard tags).
8-
# TYPE admission_webhooks_mutation_errors gauge
9-
admission_webhooks_mutation_errors{mutation_type="agent_config"} 1
6+
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="agent_sidecar",status="success"} 1
7+
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="cws_exec_instrumentation",status="success"} 1
8+
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="lib_injection",status="success"} 1
9+
admission_webhooks_mutation_attempts{error="",injected="false",mutation_type="standard_tags",status="success"} 2
10+
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="agent_config",status="success"} 2
11+
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="agent_sidecar",status="success"} 1
12+
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="cws_pod_instrumentation",status="success"} 2
13+
admission_webhooks_mutation_attempts{error="",injected="true",mutation_type="lib_injection",status="success"} 1
1014
# HELP admission_webhooks_reconcile_errors Number of reconcile errors per controller.
1115
# TYPE admission_webhooks_reconcile_errors gauge
1216
admission_webhooks_reconcile_errors{controller="secrets"} 5

datadog_cluster_agent/tests/test_datadog_cluster_agent.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
'admission_webhooks.library_injection_attempts',
1818
'admission_webhooks.library_injection_errors',
1919
'admission_webhooks.mutation_attempts',
20-
'admission_webhooks.mutation_errors',
2120
'admission_webhooks.patcher.attempts',
2221
'admission_webhooks.patcher.completed',
2322
'admission_webhooks.patcher.errors',

0 commit comments

Comments
 (0)