Fix compilation warnings and errors

Author: L3n41c

CHANGELOG.md

@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Added
 - Introduced the ability for users to configure lading's sample rate,
   configuration option `sample_period_milliseconds` in `lading.yaml`.
+- Introduce a `container` generator able to generate an arbitrary number
+  of docker containers
 
 ## [0.25.4]
 ## Changed

examples/lading-container.yaml

@@ -1,9 +1,9 @@
 generator:
   - container:
-      repository: ghcr.io/scottopell/randomreader
+      repository: busybox
       tag: latest
-      args: [ "--buffer-size-mb", "10" ]
+      args:
+        - sleep
+        - infinity
 
-blackhole:
-  - http:
-      binding_addr: "0.0.0.0:8080"
+blackhole: []

lading/src/bin/payloadtool.rs

@@ -131,6 +131,7 @@ fn check_generator(config: &lading::generator::Config) -> Result<(), Error> {
         }
         lading::generator::Inner::ProcessTree(_) => unimplemented!("ProcessTree not supported"),
         lading::generator::Inner::ProcFs(_) => unimplemented!("ProcFs not supported"),
+        lading::generator::Inner::Container(_) => unimplemented!("Container not supported"),
     };
 
     Ok(())

lading/src/generator/container.rs

@@ -16,7 +16,6 @@ use bollard::image::CreateImageOptions;
 use bollard::secret::ContainerCreateResponse;
 use bollard::Docker;
 use serde::{Deserialize, Serialize};
-use tokio::pin;
 use tokio_stream::StreamExt;
 use tracing::{info, warn};
 use uuid::Uuid;
@@ -64,8 +63,9 @@ impl Container {
     ///
     /// Will return an error if config parsing fails or runtime setup fails
     /// in the future. For now, always succeeds.
+    #[allow(clippy::needless_pass_by_value)]
     pub fn new(
-        general: General,
+        _general: General,
         config: &Config,
         shutdown: lading_signal::Watcher,
     ) -> Result<Self, Error> {