Added support for https in expvar scraping (#1213)

* Added support for https with no tls certificate verification

Signed-off-by: Caleb Metz <[email protected]>

* Added more error information to requests

Signed-off-by: Caleb Metz <[email protected]>

* Added more error info to json parsing of expvar results

Signed-off-by: Caleb Metz <[email protected]>

* Updated sleep from default 1sec to `sample_period`

Signed-off-by: Caleb Metz <[email protected]>

* Added CHANGELOG and updated comment.

Signed-off-by: Caleb Metz <[email protected]>

---------

Signed-off-by: Caleb Metz <[email protected]>

Author: cmetz100

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Added
 - Introduced the ability for users to configure lading's sample rate,
   configuration option `sample_period_milliseconds` in `lading.yaml`.
+- Users can now configure expvar scraping on https endpoints, skipping certificate validation.
 
 ## [0.25.4]
 ## Changed

Cargo.lock

@@ -58,7 +58,7 @@ rand = { workspace = true, default-features = false, features = [
   "std_rng",
 ] }
 regex = { version = "1.11" }
-reqwest = { version = "0.12", default-features = false, features = ["json"] }
+reqwest = { version = "0.12", default-features = false, features = ["json", "default-tls"] }
 rustc-hash = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }

lading/Cargo.toml

@@ -1,7 +1,7 @@
 //! Expvar target metrics fetcher
 //!
 //! This module scrapes Go expvar formatted metrics from the target software.
-//! The metrics are formatted as a JSON tree that is fetched over HTTP.
+//! The metrics are formatted as a JSON tree that is fetched over HTTP or HTTPS.
 
 use std::time::Duration;
 
@@ -80,24 +80,34 @@ impl Expvar {
             self.sample_period
         );
 
-        let client = reqwest::Client::new();
+        // Disable certificate validation
+        let client = reqwest::ClientBuilder::new()
+            .danger_accept_invalid_certs(true)
+            .build()
+            .expect("Failed to build http/https client");
 
         let server = async move {
             loop {
                 tokio::time::sleep(self.sample_period).await;
-                let Ok(resp) = client
+                let resp = match client
                     .get(&self.config.uri)
                     .timeout(self.sample_period)
                     .send()
                     .await
-                else {
-                    info!("failed to get expvar uri");
-                    continue;
+                {
+                    Ok(resp) => resp, // If successful, return the response
+                    Err(err) => {
+                        info!("Failed to get expvar URI: {}", err);
+                        continue; // Skip the iteration on error
+                    }
                 };
 
-                let Ok(json) = resp.json::<Value>().await else {
-                    info!("failed to parse expvar json");
-                    continue;
+                let json = match resp.json::<Value>().await {
+                    Ok(json) => json, // Successfully parsed JSON
+                    Err(err) => {
+                        info!("Failed to parse expvar JSON: {}", err);
+                        continue; // Skip the iteration on error
+                    }
                 };
 
                 // Add lading labels including user defined tags for this endpoint