Skip to content

Commit d97bd73

Browse files
authored
Fix incorrect pool assignment in dogstatsd/event, service_check (#1750)
### What does this PR do? This commit corrects a small bug introduced in PR #1732. I have a notion of how to make these pool handles type-safe but that's an intrusive change I do not want to bundle here.
1 parent 6bf3a73 commit d97bd73

3 files changed

Lines changed: 116 additions & 30 deletions

File tree

lading_payload/fuzz/Cargo.lock

Lines changed: 113 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lading_payload/src/dogstatsd/event.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ impl fmt::Display for Event<'_> {
143143
.expect("invalid tag key handle");
144144
let value = self
145145
.pools
146-
.randomstring
146+
.tag_value
147147
.using_handle(tag.value)
148148
.expect("invalid tag value handle");
149149
write!(f, "{key}:{value}")?;

lading_payload/src/dogstatsd/service_check.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ impl fmt::Display for ServiceCheck<'_> {
9393
for tag in tags {
9494
let key = self
9595
.pools
96-
.randomstring
96+
.tag_name
9797
.using_handle(tag.key)
9898
.expect("invalid tag key handle");
9999
let value = self
100100
.pools
101-
.tag_name
101+
.tag_value
102102
.using_handle(tag.value)
103103
.expect("invalid tag value handle");
104104
write!(f, "{key}:{value}")?;

0 commit comments

Comments
 (0)