From d6a0f46ab2b2ce0c9859073dfd709db31c47b2e2 Mon Sep 17 00:00:00 2001
From: vianney <vianney.ruhlmann@datadoghq.com>
Date: Wed, 26 Jun 2024 14:46:44 +0200
Subject: [PATCH] Fix clippy errors

---
 Cargo.lock                                 | 1 +
 trace-normalization/src/normalize_utils.rs | 9 +++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 93c5cf2a03..d0c3b607a7 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1376,6 +1376,7 @@ name = "datadog-trace-normalization"
 version = "10.0.0"
 dependencies = [
  "anyhow",
+ "criterion",
  "datadog-trace-protobuf",
  "duplicate",
  "rand",
diff --git a/trace-normalization/src/normalize_utils.rs b/trace-normalization/src/normalize_utils.rs
index 0c52db03eb..a1ba981da0 100644
--- a/trace-normalization/src/normalize_utils.rs
+++ b/trace-normalization/src/normalize_utils.rs
@@ -26,7 +26,7 @@ pub fn normalize_service(svc: &mut String) {
     truncate_utf8(svc, MAX_SERVICE_LEN);
     normalize_tag(svc);
     if svc.is_empty() {
-        *svc = DEFAULT_SERVICE_NAME.to_owned();
+        DEFAULT_SERVICE_NAME.clone_into(svc);
     }
 }
 
@@ -35,13 +35,14 @@ pub fn normalize_name(name: &mut String) {
     truncate_utf8(name, MAX_NAME_LEN);
     normalize_metric_name(name);
     if name.is_empty() {
-        *name = DEFAULT_SPAN_NAME.to_owned();
+        DEFAULT_SPAN_NAME.clone_into(name);
     }
 }
 
+#[allow(clippy::ptr_arg)]
 pub fn normalize_resource(resource: &mut String, name: &str) {
     if resource.is_empty() {
-        *resource = name.to_owned();
+        name.clone_into(resource);
     }
 }
 
@@ -55,7 +56,7 @@ pub fn normalize_span_start_duration(start: &mut i64, duration: &mut i64) {
     if *duration < 0 {
         *duration = 0;
     }
-    if *duration > std::i64::MAX - *start {
+    if *duration > i64::MAX - *start {
         *duration = 0;
     }