diff --git a/environments/etc/manifests/site.pp b/environments/etc/manifests/site.pp index 8011f191..68c5cc3c 100644 --- a/environments/etc/manifests/site.pp +++ b/environments/etc/manifests/site.pp @@ -1,5 +1,25 @@ node default { + class { 'datadog_agent': - api_key => 'somenonnullapikeythats32charlong', + api_key => 'somenonnullapikeythats32charlong', + agent_extra_options => { + use_http => true, + }, + facts_to_tags => ['osfamily'], + integrations => { + 'ntp' => { + init_config => {}, + instances => [{ + offset_threshold => 30, + }], + }, + }, } + + class { 'datadog_agent::integrations::apache': + url => 'http://example.com/server-status?auto', + username => 'status', + password => 'hunter1', + } + } diff --git a/kitchen.yml b/kitchen.yml index 4528387a..f3721991 100644 --- a/kitchen.yml +++ b/kitchen.yml @@ -28,6 +28,7 @@ platforms: - mkdir /home/kitchen/puppet - printf <%= File.read('environments/etc/Puppetfile').inspect %> > /home/kitchen/puppet/Puppetfile + - gem install bundler -v '= 1.17.3' - gem install r10k -v 2.6.7 - cd /home/kitchen/puppet && r10k puppetfile install --moduledir=/tmp/modules @@ -45,6 +46,7 @@ platforms: - mkdir /home/kitchen/puppet - printf <%= File.read('environments/etc/Puppetfile').inspect %> > /home/kitchen/puppet/Puppetfile + - gem install bundler -v '= 1.17.3' - gem install r10k -v 2.6.7 - cd /home/kitchen/puppet && r10k puppetfile install --moduledir=/tmp/modules @@ -64,6 +66,7 @@ platforms: - mkdir /home/kitchen/puppet - printf <%= File.read('environments/etc/Puppetfile').inspect %> > /home/kitchen/puppet/Puppetfile + - gem install bundler -v '= 1.17.3' - gem install r10k -v 2.6.7 - cd /home/kitchen/puppet && r10k puppetfile install --moduledir=/tmp/modules @@ -81,7 +84,8 @@ platforms: provision_command: - zypper ar -G https://yum.puppet.com/puppet/sles/15/x86_64/ puppet-repo - zypper install -y puppet-agent ruby=2.5 - - gem install bundler serverspec rspec + - gem install bundler -v '= 1.17.3' + - gem install serverspec rspec - ln -s /usr/bin/rspec.ruby2.5 /usr/bin/rspec - ln -s /opt/puppetlabs/puppet/bin/puppet /usr/bin/puppet - mkdir /home/kitchen/puppet diff --git a/manifests/install_integration.pp b/manifests/install_integration.pp index d6a9e421..ab661f10 100644 --- a/manifests/install_integration.pp +++ b/manifests/install_integration.pp @@ -5,7 +5,7 @@ Boolean $third_party = false, ){ - include datadog_agent + require ::datadog_agent if $ensure == 'present' { diff --git a/manifests/integration.pp b/manifests/integration.pp index e56fa29f..7824c94c 100644 --- a/manifests/integration.pp +++ b/manifests/integration.pp @@ -7,7 +7,9 @@ Enum['present', 'absent'] $ensure = 'present', ){ - include datadog_agent + # We can't `require ::datadog_agent` from here since this class is used by the + # datadog_agent class, causing a dependency cycle. If using this class + # directly, you should define datadog_agent before datadog_agent::integration. if $::datadog_agent::_agent_major_version > 5 { $dst_dir = "${datadog_agent::params::conf_dir}/${integration}.d" diff --git a/manifests/integrations/activemq_xml.pp b/manifests/integrations/activemq_xml.pp index 4a46b8bf..77e8d688 100644 --- a/manifests/integrations/activemq_xml.pp +++ b/manifests/integrations/activemq_xml.pp @@ -52,7 +52,7 @@ Optional[Array[String]] $detailed_subscribers = [], Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/activemq_xml.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/apache.pp b/manifests/integrations/apache.pp index 163a09b1..09cccaf7 100644 --- a/manifests/integrations/apache.pp +++ b/manifests/integrations/apache.pp @@ -36,7 +36,7 @@ Optional[Array] $instances = undef, Optional[Array] $logs = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances { $_instances = datadog_agent::clean_empty([{ diff --git a/manifests/integrations/cacti.pp b/manifests/integrations/cacti.pp index d46f172c..b159282a 100644 --- a/manifests/integrations/cacti.pp +++ b/manifests/integrations/cacti.pp @@ -18,7 +18,7 @@ $mysql_password = undef, $rrd_path = '/var/lib/cacti/rra/', ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/cacti.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/ceph.pp b/manifests/integrations/ceph.pp index 80d19e63..b4fb7dc0 100644 --- a/manifests/integrations/ceph.pp +++ b/manifests/integrations/ceph.pp @@ -17,7 +17,7 @@ Array $tags = [ 'name:ceph_cluster' ], String $ceph_cmd = '/usr/bin/ceph', ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent file { '/etc/sudoers.d/datadog_ceph': content => "# This file is required for dd ceph \ndd-agent ALL=(ALL) NOPASSWD:/usr/bin/ceph\n" diff --git a/manifests/integrations/consul.pp b/manifests/integrations/consul.pp index 1c5d38c0..b018ef63 100644 --- a/manifests/integrations/consul.pp +++ b/manifests/integrations/consul.pp @@ -33,7 +33,7 @@ Boolean $new_leader_checks = true, Optional[Array] $service_whitelist = [] ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/consul.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/directory.pp b/manifests/integrations/directory.pp index c6338f3d..a892abb8 100644 --- a/manifests/integrations/directory.pp +++ b/manifests/integrations/directory.pp @@ -65,7 +65,7 @@ String $pattern = '', Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $directory == '' { fail('bad directory argument and no instances hash provided') diff --git a/manifests/integrations/disk.pp b/manifests/integrations/disk.pp index ea3f8377..124b8a24 100644 --- a/manifests/integrations/disk.pp +++ b/manifests/integrations/disk.pp @@ -81,7 +81,7 @@ Optional[String] $excluded_disk_re = undef, # deprecated in agent versions >6.9 Optional[String] $excluded_mountpoint_re = undef, # deprecated in agent versions >6.9 ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent validate_legacy('Optional[String]', 'validate_re', $all_partitions, '^(no|yes)$') diff --git a/manifests/integrations/dns_check.pp b/manifests/integrations/dns_check.pp index fbe43848..ce60f877 100644 --- a/manifests/integrations/dns_check.pp +++ b/manifests/integrations/dns_check.pp @@ -33,7 +33,7 @@ } ] ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/dns_check.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/docker_daemon.pp b/manifests/integrations/docker_daemon.pp index 30ef4683..1be8bc64 100644 --- a/manifests/integrations/docker_daemon.pp +++ b/manifests/integrations/docker_daemon.pp @@ -55,7 +55,7 @@ $collect_labels_as_tags = [], $event_attributes_as_tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent exec { 'dd-agent-should-be-in-docker-group': command => "/usr/sbin/usermod -aG ${group} ${datadog_agent::params::dd_user}", diff --git a/manifests/integrations/elasticsearch.pp b/manifests/integrations/elasticsearch.pp index e335fa63..bdae1fc0 100644 --- a/manifests/integrations/elasticsearch.pp +++ b/manifests/integrations/elasticsearch.pp @@ -37,7 +37,7 @@ Optional[String] $username = undef, Optional[Array] $instances = undef ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent # $ssl_verify can be a bool or a string # https://github.com/DataDog/dd-agent/blob/master/checks.d/elastic.py#L454-L455 diff --git a/manifests/integrations/fluentd.pp b/manifests/integrations/fluentd.pp index 89e683d9..d6b5ffd5 100644 --- a/manifests/integrations/fluentd.pp +++ b/manifests/integrations/fluentd.pp @@ -21,7 +21,7 @@ $monitor_agent_url = 'http://localhost:24220/api/plugins.json', Optional[Array] $plugin_ids = [], ) inherits datadog_agent::params { - include ::datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/fluentd.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/generic.pp b/manifests/integrations/generic.pp index 880f1722..935273db 100644 --- a/manifests/integrations/generic.pp +++ b/manifests/integrations/generic.pp @@ -21,7 +21,7 @@ Optional[String] $integration_name = undef, Optional[String] $integration_contents = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/${integration_name}.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/haproxy.pp b/manifests/integrations/haproxy.pp index fa1d6bfe..12c7b473 100644 --- a/manifests/integrations/haproxy.pp +++ b/manifests/integrations/haproxy.pp @@ -22,7 +22,7 @@ $options = {}, Optional[Array] $instances = undef ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $url { $_instances = [{ diff --git a/manifests/integrations/http_check.pp b/manifests/integrations/http_check.pp index 8c4be8da..a0b218b9 100644 --- a/manifests/integrations/http_check.pp +++ b/manifests/integrations/http_check.pp @@ -201,7 +201,7 @@ Optional[Array] $logs = undef, $ca_certs = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $url { $_instances = [{ diff --git a/manifests/integrations/jenkins.pp b/manifests/integrations/jenkins.pp index 708aaf59..59cdfa6a 100644 --- a/manifests/integrations/jenkins.pp +++ b/manifests/integrations/jenkins.pp @@ -16,7 +16,7 @@ class datadog_agent::integrations::jenkins( $path = '/var/lib/jenkins' ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/jenkins.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/jmx.pp b/manifests/integrations/jmx.pp index e2246c1e..3920d3f2 100644 --- a/manifests/integrations/jmx.pp +++ b/manifests/integrations/jmx.pp @@ -65,7 +65,7 @@ $init_config = {}, $instances = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/jmx.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/kafka.pp b/manifests/integrations/kafka.pp index fae25ca7..373b6aae 100644 --- a/manifests/integrations/kafka.pp +++ b/manifests/integrations/kafka.pp @@ -65,7 +65,7 @@ Optional[Hash[String[1], String[1]]] $tags = undef, Optional[Array[Hash[String[1], Data]]] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $host and $port { $servers = [{ diff --git a/manifests/integrations/kong.pp b/manifests/integrations/kong.pp index b90f244b..73c3bf53 100644 --- a/manifests/integrations/kong.pp +++ b/manifests/integrations/kong.pp @@ -32,7 +32,7 @@ } ] ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/kong.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/kubernetes.pp b/manifests/integrations/kubernetes.pp index e43d871b..d7ba17ea 100644 --- a/manifests/integrations/kubernetes.pp +++ b/manifests/integrations/kubernetes.pp @@ -30,7 +30,7 @@ $tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/kubernetes.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/kubernetes_state.pp b/manifests/integrations/kubernetes_state.pp index bdf1da11..1b5b36e7 100644 --- a/manifests/integrations/kubernetes_state.pp +++ b/manifests/integrations/kubernetes_state.pp @@ -22,7 +22,7 @@ $tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/kubernetes_state.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/linux_proc_extras.pp b/manifests/integrations/linux_proc_extras.pp index 9531bea6..92cb28fd 100644 --- a/manifests/integrations/linux_proc_extras.pp +++ b/manifests/integrations/linux_proc_extras.pp @@ -16,7 +16,7 @@ class datadog_agent::integrations::linux_proc_extras( $tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/linux_proc_extras.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/logs.pp b/manifests/integrations/logs.pp index 7e36b53a..2b7e1536 100644 --- a/manifests/integrations/logs.pp +++ b/manifests/integrations/logs.pp @@ -40,7 +40,7 @@ Array $logs = [], ) inherits datadog_agent::params { unless $::datadog_agent::_agent_major_version == 5 { - include datadog_agent + require ::datadog_agent file { "${datadog_agent::params::conf_dir}/logs.yaml": ensure => file, diff --git a/manifests/integrations/marathon.pp b/manifests/integrations/marathon.pp index dc79a1be..9797be92 100644 --- a/manifests/integrations/marathon.pp +++ b/manifests/integrations/marathon.pp @@ -16,7 +16,7 @@ $marathon_timeout = 5, $url = 'http://localhost:8080' ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/marathon.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/memcache.pp b/manifests/integrations/memcache.pp index 6610a4bd..60ed2e6f 100644 --- a/manifests/integrations/memcache.pp +++ b/manifests/integrations/memcache.pp @@ -38,7 +38,7 @@ Variant[Boolean, String] $slabs = false, Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $url { $_instances = [{ diff --git a/manifests/integrations/mesos_master.pp b/manifests/integrations/mesos_master.pp index f86572ee..6223fdea 100644 --- a/manifests/integrations/mesos_master.pp +++ b/manifests/integrations/mesos_master.pp @@ -16,7 +16,7 @@ $mesos_timeout = 10, $url = 'http://localhost:5050' ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if $::datadog_agent::_agent_major_version > 5 { $dst_dir = "${datadog_agent::params::conf_dir}/mesos.d" diff --git a/manifests/integrations/mongo.pp b/manifests/integrations/mongo.pp index d6829643..c566aa22 100644 --- a/manifests/integrations/mongo.pp +++ b/manifests/integrations/mongo.pp @@ -59,7 +59,7 @@ class datadog_agent::integrations::mongo( Array $servers = [{'host' => 'localhost', 'port' => '27017'}] ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/mongo.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/mysql.pp b/manifests/integrations/mysql.pp index ed2dee0b..0781b121 100644 --- a/manifests/integrations/mysql.pp +++ b/manifests/integrations/mysql.pp @@ -81,7 +81,7 @@ Optional[Array] $instances = undef, Optional[Array] $logs = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if ($host == undef and $sock == undef) or ($host != undef and $port == undef and $sock == undef) { diff --git a/manifests/integrations/network.pp b/manifests/integrations/network.pp index 1ee813a2..77897f15 100644 --- a/manifests/integrations/network.pp +++ b/manifests/integrations/network.pp @@ -25,7 +25,7 @@ String $excluded_interface_re = '', Boolean $combine_connection_states = true, ) inherits datadog_agent::params { - include ::datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/network.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/nginx.pp b/manifests/integrations/nginx.pp index f40b895f..14a4764a 100644 --- a/manifests/integrations/nginx.pp +++ b/manifests/integrations/nginx.pp @@ -61,7 +61,7 @@ Array $instances = [], Optional[Array] $logs = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/nginx.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/ntp.pp b/manifests/integrations/ntp.pp index 2d65d25a..8d955113 100644 --- a/manifests/integrations/ntp.pp +++ b/manifests/integrations/ntp.pp @@ -30,7 +30,7 @@ $version = undef, $timeout = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/ntp.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/oom_kill.pp b/manifests/integrations/oom_kill.pp index 30e46dad..840374b9 100644 --- a/manifests/integrations/oom_kill.pp +++ b/manifests/integrations/oom_kill.pp @@ -22,7 +22,7 @@ class datadog_agent::integrations::oom_kill( Array $instances = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $dst_dir = "${datadog_agent::params::conf_dir}/oom_kill.d" file { $dst_dir: diff --git a/manifests/integrations/pgbouncer.pp b/manifests/integrations/pgbouncer.pp index b1d595f1..59747525 100644 --- a/manifests/integrations/pgbouncer.pp +++ b/manifests/integrations/pgbouncer.pp @@ -51,7 +51,7 @@ Array $tags = [], Array $pgbouncers = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/pgbouncer.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/php_fpm.pp b/manifests/integrations/php_fpm.pp index 96b45a96..ab957fda 100644 --- a/manifests/integrations/php_fpm.pp +++ b/manifests/integrations/php_fpm.pp @@ -35,7 +35,7 @@ $instances = undef, $use_fastcgi = 'false' ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances { $_instances = [{ diff --git a/manifests/integrations/postfix.pp b/manifests/integrations/postfix.pp index fe799cd4..3a274293 100644 --- a/manifests/integrations/postfix.pp +++ b/manifests/integrations/postfix.pp @@ -34,7 +34,7 @@ Optional[Array] $tags = [], Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $directory { $_instances = [{ diff --git a/manifests/integrations/postgres.pp b/manifests/integrations/postgres.pp index 9d98dcc2..1b9ff9e7 100644 --- a/manifests/integrations/postgres.pp +++ b/manifests/integrations/postgres.pp @@ -100,7 +100,7 @@ Hash $custom_metrics = {}, Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/postgres.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/process.pp b/manifests/integrations/process.pp index 1a31137b..ea80fdda 100644 --- a/manifests/integrations/process.pp +++ b/manifests/integrations/process.pp @@ -45,7 +45,7 @@ $init_config = {}, Array $processes = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if $hiera_processes { $local_processes = lookup({ 'name' => 'datadog_agent::integrations::process::processes', 'merge' => 'unique', 'default_value' => $processes }) diff --git a/manifests/integrations/rabbitmq.pp b/manifests/integrations/rabbitmq.pp index 36b82dff..62c79443 100644 --- a/manifests/integrations/rabbitmq.pp +++ b/manifests/integrations/rabbitmq.pp @@ -65,7 +65,7 @@ Array $exchanges_regexes = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/rabbitmq.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/redis.pp b/manifests/integrations/redis.pp index 9d5db2b9..aee7d93f 100644 --- a/manifests/integrations/redis.pp +++ b/manifests/integrations/redis.pp @@ -53,7 +53,7 @@ Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if $ports == undef { $_ports = [ $port ] diff --git a/manifests/integrations/riak.pp b/manifests/integrations/riak.pp index 78437b3b..aaa09f09 100644 --- a/manifests/integrations/riak.pp +++ b/manifests/integrations/riak.pp @@ -22,7 +22,7 @@ String $url = 'http://localhost:8098/stats', Array $tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/riak.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/snmp.pp b/manifests/integrations/snmp.pp index ca486be5..64bb9f38 100755 --- a/manifests/integrations/snmp.pp +++ b/manifests/integrations/snmp.pp @@ -60,7 +60,7 @@ $snmp_v2_instances = [], $snmp_v3_instances = [], ) inherits datadog_agent::params { - include ::datadog_agent + require ::datadog_agent $versioned_instances = { 1 => $snmp_v1_instances, diff --git a/manifests/integrations/solr.pp b/manifests/integrations/solr.pp index b5ea60ba..1f9108d8 100644 --- a/manifests/integrations/solr.pp +++ b/manifests/integrations/solr.pp @@ -36,7 +36,7 @@ $trust_store_password = undef, $tags = {}, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/solr.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/ssh.pp b/manifests/integrations/ssh.pp index ada1d9e3..09099065 100644 --- a/manifests/integrations/ssh.pp +++ b/manifests/integrations/ssh.pp @@ -35,7 +35,7 @@ $private_key_file = undef, $add_missing_keys = true, ) inherits datadog_agent::params { - include ::datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/ssh.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/supervisord.pp b/manifests/integrations/supervisord.pp index 3019ef1b..d2b14967 100644 --- a/manifests/integrations/supervisord.pp +++ b/manifests/integrations/supervisord.pp @@ -44,7 +44,7 @@ class datadog_agent::integrations::supervisord ( $instances = [{'servername' => 'server0', 'hostname' => 'localhost', 'port' => '9001'}], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/supervisord.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/system_core.pp b/manifests/integrations/system_core.pp index 8125ef45..b64f50a8 100644 --- a/manifests/integrations/system_core.pp +++ b/manifests/integrations/system_core.pp @@ -7,7 +7,7 @@ # # class datadog_agent::integrations::system_core inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/system_core.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/tcp_check.pp b/manifests/integrations/tcp_check.pp index 8b04451c..01e89bfd 100644 --- a/manifests/integrations/tcp_check.pp +++ b/manifests/integrations/tcp_check.pp @@ -97,7 +97,7 @@ Array $tags = [], Optional[Array] $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $host { $_instances = [{ diff --git a/manifests/integrations/tomcat.pp b/manifests/integrations/tomcat.pp index 9ab5baa6..c9ad10f3 100644 --- a/manifests/integrations/tomcat.pp +++ b/manifests/integrations/tomcat.pp @@ -39,7 +39,7 @@ $trust_store_password = undef, $tags = {}, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/tomcat.yaml" diff --git a/manifests/integrations/twemproxy.pp b/manifests/integrations/twemproxy.pp index 38c42005..4a8840ae 100644 --- a/manifests/integrations/twemproxy.pp +++ b/manifests/integrations/twemproxy.pp @@ -28,7 +28,7 @@ $port = '22222', $instances = undef, ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent if !$instances and $host { $_instances = [{ diff --git a/manifests/integrations/varnish.pp b/manifests/integrations/varnish.pp index 3a348a0b..92005446 100644 --- a/manifests/integrations/varnish.pp +++ b/manifests/integrations/varnish.pp @@ -26,7 +26,7 @@ $instance_name = undef, $tags = [], ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/varnish.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/integrations/zk.pp b/manifests/integrations/zk.pp index 0ef8df0d..7732ce7a 100644 --- a/manifests/integrations/zk.pp +++ b/manifests/integrations/zk.pp @@ -30,7 +30,7 @@ class datadog_agent::integrations::zk ( $servers = [{'host' => 'localhost', 'port' => '2181'}] ) inherits datadog_agent::params { - include datadog_agent + require ::datadog_agent $legacy_dst = "${datadog_agent::params::legacy_conf_dir}/zk.yaml" if $::datadog_agent::_agent_major_version > 5 { diff --git a/manifests/reports.pp b/manifests/reports.pp index a175e8f8..daa9dda9 100644 --- a/manifests/reports.pp +++ b/manifests/reports.pp @@ -33,7 +33,7 @@ } else { - include datadog_agent + require ::datadog_agent if $manage_dogapi_gem { $rubydev_package = $datadog_agent::params::rubydev_package diff --git a/spec/classes/datadog_agent_integrations_zk_spec.rb b/spec/classes/datadog_agent_integrations_zk_spec.rb index efb3aad8..332089af 100644 --- a/spec/classes/datadog_agent_integrations_zk_spec.rb +++ b/spec/classes/datadog_agent_integrations_zk_spec.rb @@ -12,6 +12,9 @@ end it { is_expected.to compile.with_all_deps } + + it { is_expected.to contain_class('datadog_agent::params') } + it { is_expected.to contain_file(conf_file).with( owner: DD_USER,