Skip to content

Commit 47454e1

Browse files
cbeauchesnecbeauchesne
authored
Activate ruff rules on tests/ folder (#4062)
1 parent bf45ded commit 47454e1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+94
-69
lines changed

Diff for: ‎pyproject.toml

-7
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ ignore = [
188188
"ARG002", # 177 occurences [ ] unused-method-argument
189189
"E501", # 159 occurences [ ] line-too-long
190190
"SIM117", # 127 occurences [ ] multiple-with-statements
191-
"TID252", # 77 occurences [*] relative-imports
192191
"N806", # 76 occurences [ ] non-lowercase-variable-in-function
193192
"FBT003", # 67 occurences [ ] boolean-positional-value-in-call
194193
"D200", # 52 occurences [*] fits-on-one-line
@@ -205,13 +204,11 @@ ignore = [
205204
"T201", # 15 occurences [*] print
206205
"FBT001", # 12 occurences [ ] boolean-type-hint-positional-argument
207206
"SLF001", # 12 occurences [ ] private-member-access
208-
"UP035", # 12 occurences [ ] deprecated-import
209207
"S105", # 10 occurences [ ] hardcoded-password-string
210208
"RET503", # 9 occurences [*] implicit-return
211209
"SIM115", # 9 occurences [ ] open-file-with-context-handler
212210
"RUF015", # 9 occurences [*] unnecessary-iterable-allocation-for-first-element
213211
"SIM108", # 8 occurences [*] if-else-block-instead-of-if-exp
214-
"PTH120", # 8 occurences [ ] os-path-dirname
215212
"TRY301", # 8 occurences [ ] raise-within-try
216213
"ANN206", # 7 occurences [ ] missing-return-type-class-method
217214
"B011", # 7 occurences [*] assert-false
@@ -223,13 +220,9 @@ ignore = [
223220
"PT011", # 5 occurences [ ] pytest-raises-too-broad
224221
"E731", # 5 occurences [*] lambda-assignment
225222
"RUF005", # 5 occurences [ ] collection-literal-concatenation
226-
"PTH103", # 4 occurences [ ] os-makedirs
227223
"PLW2901", # 4 occurences [ ] redefined-loop-name
228-
"PTH112", # 3 occurences [ ] os-path-isdir
229224
"ASYNC230", # 2 occurences [ ] blocking-open-call-in-async-function
230225
"S605", # 2 occurences [ ] start-process-with-a-shell
231-
"PTH100", # 2 occurences [ ] os-path-abspath
232-
"PTH109", # 2 occurences [ ] os-getcwd
233226

234227
# keep those exceptions
235228
"C400", # unnecessary-generator-list: explicit list is more readable for non-python users

Diff for: ‎tests/appsec/iast/sink/test_code_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_stack_traces, validate_extended_location_data
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_stack_traces, validate_extended_location_data
77

88

99
@features.iast_sink_code_injection

Diff for: ‎tests/appsec/iast/sink/test_command_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_command_injection

Diff for: ‎tests/appsec/iast/sink/test_email_html_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import missing_feature, features, weblog, rfc
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_email_html_injection

Diff for: ‎tests/appsec/iast/sink/test_hardcoded_passwords.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import weblog, features, context, rfc
6-
from ..utils import get_hardcoded_vulnerabilities, validate_stack_traces
6+
from tests.appsec.iast.utils import get_hardcoded_vulnerabilities, validate_stack_traces
77

88
# Test_HardcodedPasswords doesn't inherit from BaseSinkTest
99
# Hardcode passwords detection implementation change a lot between different languages

Diff for: ‎tests/appsec/iast/sink/test_hardcoded_secrets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, context, rfc, weblog
6-
from ..utils import get_hardcoded_vulnerabilities, validate_stack_traces
6+
from tests.appsec.iast.utils import get_hardcoded_vulnerabilities, validate_stack_traces
77

88
# Test_HardcodedSecrets and Test_HardcodedSecretsExtended don't inherit from BaseSinkTest
99
# Hardcode secrets detection implementation change a lot between different languages

Diff for: ‎tests/appsec/iast/sink/test_header_injection.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, features, missing_feature, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces, assert_iast_vulnerability
6+
from tests.appsec.iast.utils import (
7+
BaseSinkTest,
8+
validate_extended_location_data,
9+
validate_stack_traces,
10+
assert_iast_vulnerability,
11+
)
712

813

914
class _BaseTestHeaderInjectionReflectedExclusion:

Diff for: ‎tests/appsec/iast/sink/test_hsts_missing_header.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_hsts_missing_header

Diff for: ‎tests/appsec/iast/sink/test_insecure_auth_protocol.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_insecure_auth_protocol

Diff for: ‎tests/appsec/iast/sink/test_insecure_cookie.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, bug, weblog, features, rfc, scenarios, flaky
6-
from ..utils import BaseSinkTest, BaseTestCookieNameFilter, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import (
7+
BaseSinkTest,
8+
BaseTestCookieNameFilter,
9+
validate_extended_location_data,
10+
validate_stack_traces,
11+
)
712

813

914
@features.iast_sink_insecure_cookie

Diff for: ‎tests/appsec/iast/sink/test_ldap_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_ldap_injection

Diff for: ‎tests/appsec/iast/sink/test_no_httponly_cookie.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, bug, weblog, features, rfc, scenarios, flaky
6-
from ..utils import BaseSinkTest, BaseTestCookieNameFilter, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import (
7+
BaseSinkTest,
8+
BaseTestCookieNameFilter,
9+
validate_extended_location_data,
10+
validate_stack_traces,
11+
)
712

813

914
@features.iast_sink_http_only_cookie

Diff for: ‎tests/appsec/iast/sink/test_no_samesite_cookie.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, bug, weblog, features, rfc, scenarios, flaky
6-
from ..utils import BaseSinkTest, BaseTestCookieNameFilter, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import (
7+
BaseSinkTest,
8+
BaseTestCookieNameFilter,
9+
validate_extended_location_data,
10+
validate_stack_traces,
11+
)
712

813

914
@features.iast_sink_samesite_cookie

Diff for: ‎tests/appsec/iast/sink/test_nosql_mongodb_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, scenarios, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@scenarios.integrations

Diff for: ‎tests/appsec/iast/sink/test_path_traversal.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, weblog, rfc
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_path_traversal

Diff for: ‎tests/appsec/iast/sink/test_reflection_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_reflection_injection

Diff for: ‎tests/appsec/iast/sink/test_sql_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, bug, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_sql_injection

Diff for: ‎tests/appsec/iast/sink/test_ssrf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import bug, context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_ssrf

Diff for: ‎tests/appsec/iast/sink/test_stacktrace_leak.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
from utils import features, rfc, weblog
7-
from ..utils import BaseSinkTest, validate_stack_traces
7+
from tests.appsec.iast.utils import BaseSinkTest, validate_stack_traces
88

99

1010
@features.iast_stack_trace

Diff for: ‎tests/appsec/iast/sink/test_template_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, weblog, rfc
6-
from ..utils import BaseSinkTest, validate_extended_location_data
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data
77

88

99
@features.iast_sink_template_injection

Diff for: ‎tests/appsec/iast/sink/test_trust_boundary_violation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_trustboundaryviolation

Diff for: ‎tests/appsec/iast/sink/test_untrusted_deserialization.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, weblog, rfc
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_untrusted_deserialization

Diff for: ‎tests/appsec/iast/sink/test_unvalidated_redirect.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, irrelevant, features, missing_feature, rfc, weblog
6-
from ..utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
77

88

99
def _expected_location():

Diff for: ‎tests/appsec/iast/sink/test_unvalidated_redirect_forward.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, features, missing_feature, rfc, weblog
6-
from ..utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
77

88

99
def _expected_location():

Diff for: ‎tests/appsec/iast/sink/test_weak_cipher.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# This product includes software developed at Datadog (https://www.datadoghq.com/).
33
# Copyright 2021 Datadog, Inc.
44
from utils import context, missing_feature, flaky, features, weblog, rfc
5-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
5+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
66

77

88
@features.weak_cipher_detection

Diff for: ‎tests/appsec/iast/sink/test_weak_hash.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import weblog, context, missing_feature, features, rfc, scenarios
6-
from ..utils import BaseSinkTest, assert_iast_vulnerability, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import (
7+
BaseSinkTest,
8+
assert_iast_vulnerability,
9+
validate_extended_location_data,
10+
validate_stack_traces,
11+
)
712

813

914
def _expected_location():

Diff for: ‎tests/appsec/iast/sink/test_weak_randomness.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, weblog, rfc
6-
from ..utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_weakrandomness

Diff for: ‎tests/appsec/iast/sink/test_xcontent_sniffing.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features, rfc, weblog
6-
from ..utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTest, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_xcontentsniffing

Diff for: ‎tests/appsec/iast/sink/test_xpath_injection.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, weblog, rfc
6-
from ..utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_xpathinjection

Diff for: ‎tests/appsec/iast/sink/test_xss.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, weblog, rfc
6-
from ..utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
6+
from tests.appsec.iast.utils import BaseSinkTestWithoutTelemetry, validate_extended_location_data, validate_stack_traces
77

88

99
@features.iast_sink_xss

Diff for: ‎tests/appsec/iast/source/test_body.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, bug, features
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@features.iast_source_body

Diff for: ‎tests/appsec/iast/source/test_cookie_name.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, bug, missing_feature, features
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@features.iast_source_cookie_name

Diff for: ‎tests/appsec/iast/source/test_cookie_value.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@features.iast_source_cookie_value

Diff for: ‎tests/appsec/iast/source/test_graphql_resolver.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, scenarios
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@scenarios.graphql_appsec

Diff for: ‎tests/appsec/iast/source/test_header_name.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@features.iast_source_header_name

Diff for: ‎tests/appsec/iast/source/test_header_value.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import context, missing_feature, features
6-
from ..utils import BaseSourceTest
6+
from tests.appsec.iast.utils import BaseSourceTest
77

88

99
@features.iast_source_header_value

Diff for: ‎tests/appsec/iast/source/test_kafka_key.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, scenarios
6-
from ..utils import BaseSourceTest, get_all_iast_events, get_iast_sources
6+
from tests.appsec.iast.utils import BaseSourceTest, get_all_iast_events, get_iast_sources
77

88

99
@features.iast_source_kafka_key

Diff for: ‎tests/appsec/iast/source/test_kafka_value.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright 2021 Datadog, Inc.
44

55
from utils import features, scenarios
6-
from ..utils import BaseSourceTest, get_all_iast_events, get_iast_sources
6+
from tests.appsec.iast.utils import BaseSourceTest, get_all_iast_events, get_iast_sources
77

88

99
@features.iast_source_kafka_value

0 commit comments

Comments
 (0)