Refactor dinky class loader (#2671)

* refactor: DinkyClassLoader Signed-off-by: licho <[email protected]> * Spotless Apply --------- Signed-off-by: licho <[email protected]> Co-authored-by: leechor <[email protected]>
DataLinkDC · Dec 18, 2023 · 3781a72 · 3781a72
1 parent 6c73913
commit 3781a72
Showing 1 changed file with 17 additions and 22 deletions.
diff --git a/dinky-common/src/main/java/org/dinky/classloader/DinkyClassLoader.java b/dinky-common/src/main/java/org/dinky/classloader/DinkyClassLoader.java
@@ -42,32 +42,34 @@ public class DinkyClassLoader extends URLClassLoader {
     FlinkUdfPathContextHolder udfPathContextHolder = new FlinkUdfPathContextHolder();
 
     public DinkyClassLoader(URL[] urls, ClassLoader parent) {
-        super(new URL[] {}, parent);
+        this(urls, parent, null);
     }
 
     public DinkyClassLoader(Collection<File> fileSet, ClassLoader parent) {
-        super(new URL[] {}, parent);
-        addURLs(fileSet);
+        this(convertFilesToUrls(fileSet), parent, null);
     }
 
     public DinkyClassLoader(URL[] urls) {
-        super(new URL[] {});
+        this(urls, Thread.currentThread().getContextClassLoader(), null);
     }
 
     public DinkyClassLoader(URL[] urls, ClassLoader parent, URLStreamHandlerFactory factory) {
-        super(new URL[] {}, parent, factory);
-    }
-
-    // this class factory method
-    public static DinkyClassLoader build() {
-        return new DinkyClassLoader(new URL[] {});
+        super(urls, parent, factory);
     }
 
     // class factory method with urls parameters
     public static DinkyClassLoader build(URL... urls) {
         return new DinkyClassLoader(urls);
     }
 
+    public static DinkyClassLoader build(URL[] urls, ClassLoader parent) {
+        return new DinkyClassLoader(urls, parent);
+    }
+
+    public static DinkyClassLoader build(ClassLoader parent) {
+        return new DinkyClassLoader(new URL[] {}, parent);
+    }
+
     // return udfPathContextHolder
     public FlinkUdfPathContextHolder getUdfPathContextHolder() {
         return udfPathContextHolder;
@@ -80,30 +82,23 @@ public void addURLs(URL... urls) {
     }
 
     public void addURLs(Collection<File> fileSet) {
-        URL[] urls = fileSet.stream()
-                .map(x -> {
-                    try {
-                        return x.toURI().toURL();
-                    } catch (MalformedURLException e) {
-                        throw new RuntimeException(e);
-                    }
-                })
-                .toArray(URL[]::new);
+        URL[] urls = convertFilesToUrls(fileSet);
         addURLs(urls);
     }
 
-    public void addURLs(List<File> files) {
-        files.stream()
+    private static URL[] convertFilesToUrls(Collection<File> fileSet) {
+        return fileSet.stream()
                 .map(x -> {
                     try {
                         return x.toURI().toURL();
                     } catch (MalformedURLException e) {
                         throw new RuntimeException(e);
                     }
                 })
-                .forEach(this::addURL);
+                .toArray(URL[]::new);
     }
 
+    @Override
     public void addURL(URL url) {
         super.addURL(url);
     }