Merge branch 'main' into fix/dish-pin-colour

Author: warm-coolguy

.github/workflows/publish-packages.yml

@@ -36,5 +36,5 @@ jobs:
             echo "Released and tagged $TAG"
           done
       - run: node ./scripts/createRelease ${{ env.TAGS }}
-        with:
+        env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

arcana.md

@@ -8,8 +8,8 @@ For these cases, this not-so-secret file denotes our not-anymore-arcane knowledg
 
 1. Draw a dependency tree of POLAR packages with changes documented as `"unpublished"` in their respective `CHANGELOG.md` files.
 2. Start with the leafs. Update the version from `"unpublished"` to the appropriate version indicated by the nature of changes. If required, change the package.json dependencies to refer to minimum versions of dependencies used.
-3. Push to main. A pipeline is now running that detects the CHANGELOG change, updates the version, publishes the package to NPM, and creates a tag `@polar/package-name@x.y.z`.
-4. Create new release note on GitHub. Select the previously created tag, use it as title, and copy the relevant changelog. Link to the NPM package. If it's a client, add the NPM package to the artifacts for an easier download. See previous releases for formatting of contents and artifacts.
+3. Push to main. A pipeline is now running that detects the CHANGELOG change, updates the version, publishes the package to NPM, creates a tag `@polar/package-name@x.y.z`, and procudes a GitHub release.
+4. If it's a client, add the NPM package to the release artifacts for an easier download. See previous releases for formatting of contents and artifacts.
 5. Delete leafs from tree made in `1`. Go back to `2` until the tree is empty.
 
 ## Update process

package-lock.json

@@ -37,10 +37,8 @@
     "test:dev": "jest --coverage --coverageReporters=text --watchAll",
     "test:coverage": "jest --coverage"
   },
-  "dependencies": {
-    "@actions/github": "^5.1.1"
-  },
   "devDependencies": {
+    "@actions/github": "^5.1.1",
     "@babel/core": "^7.21.3",
     "@babel/preset-env": "^7.20.2",
     "@cyclonedx/cyclonedx-npm": "^1.7.2",

package.json

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## unpublished
+
+- Fix: Increase type precision of EPSG codes from `string` to `EPSG:${string}`.
+
 ## 1.0.0
 
 Initial release.

packages/lib/getFeatures/CHANGELOG.md

@@ -23,7 +23,7 @@ export function getGazetteerFeatures(
   version: WFSVersion,
   memberSuffix: MemberSuffix,
   namespaces: string[],
-  epsg: string,
+  epsg: `EPSG:${string}`,
   options: AdditionalSearchOptions = {}
 ): Promise<FeatureCollection> {
   let requestUrl = Object.entries(input).reduce(

packages/lib/getFeatures/gazetteer/index.ts

@@ -16,7 +16,7 @@ export function parseGazetteerResponse(
   response: Response,
   memberSuffix: MemberSuffix,
   namespaces: string[],
-  epsg: string,
+  epsg: `EPSG:${string}`,
   title?: string | string[]
 ): Promise<FeatureCollection> {
   return response.text().then((text) => {

packages/lib/getFeatures/gazetteer/parse.ts

@@ -15,7 +15,7 @@ export interface AdditionalSearchOptions {
 /** Adds the possibility to have a 'title' attribute in a GeoJSON Feature */
 export interface PolarGeoJsonFeature extends GeoJsonFeature {
   /** The projection of the coordinates of the features */
-  epsg: string
+  epsg: `EPSG:${string}`
   /** Which fieldName to use for display purposes; e.g. used in the AddressSearch for the result list */
   title?: string
 }

packages/lib/getFeatures/types.ts

@@ -1,6 +1,8 @@
 # CHANGELOG
 
-## 1.3.0-mock.0
+## unpublished
+
+- Fix: Test now uses a mock EPSG code instead of an empty string.
 
 ## 1.2.0