Skip to content

Commit 298aff9

Browse files
committed
Migrate @polar/plugin-fullscreen to the new rollup setup
Also, import the styles from the package in all clients.
1 parent 7a5f431 commit 298aff9

File tree

6 files changed

+64
-3
lines changed

6 files changed

+64
-3
lines changed

packages/clients/generic/src/polar-client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import '@polar/plugin-export/styles.css'
1616
import Filter from '@polar/plugin-filter'
1717
import '@polar/plugin-filter/styles.css'
1818
import Fullscreen from '@polar/plugin-fullscreen'
19+
import '@polar/plugin-fullscreen/styles.css'
1920
import GeoLocation from '@polar/plugin-geo-location'
2021
import Gfi from '@polar/plugin-gfi'
2122
import '@polar/plugin-gfi/styles.css'

packages/clients/meldemichel/src/utils/createMenus.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Filter from '@polar/plugin-filter'
22
import '@polar/plugin-filter/styles.css'
33
import Fullscreen from '@polar/plugin-fullscreen'
4+
import '@polar/plugin-fullscreen/styles.css'
45
import Gfi from '@polar/plugin-gfi'
56
import '@polar/plugin-gfi/styles.css'
67
import LayerChooser from '@polar/plugin-layer-chooser'

packages/clients/snowbox/src/addPlugins.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import Draw from '@polar/plugin-draw'
99
import Export from '@polar/plugin-export'
1010
import '@polar/plugin-export/styles.css'
1111
import Fullscreen from '@polar/plugin-fullscreen'
12+
import '@polar/plugin-fullscreen/styles.css'
1213
import GeoLocation from '@polar/plugin-geo-location'
1314
import Gfi from '@polar/plugin-gfi'
1415
import '@polar/plugin-gfi/styles.css'

packages/plugins/Fullscreen/package.json

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,32 @@
55
"license": "EUPL-1.2",
66
"type": "module",
77
"author": "Dataport AöR <[email protected]>",
8-
"main": "src/index.ts",
8+
"main": "dist/index.js",
9+
"types": "dist/index.d.ts",
10+
"module": "dist/index.js",
11+
"exports": {
12+
".": {
13+
"import": "./dist/index.js",
14+
"require": "./dist/index.js"
15+
},
16+
"./styles.css": {
17+
"import": "./dist/index.css",
18+
"require": "./dist/index.css"
19+
}
20+
},
921
"repository": {
1022
"type": "git",
1123
"url": "https://github.com/Dataport/polar.git",
1224
"directory": "packages/plugins/Fullscreen"
1325
},
1426
"files": [
15-
"src/**/*",
27+
"dist/**",
1628
"CHANGELOG.md"
1729
],
30+
"scripts": {
31+
"bundle": "tsc --declaration --emitDeclarationOnly && rollup -c",
32+
"preversion": "npm run bundle"
33+
},
1834
"peerDependencies": {
1935
"@repositoryname/vuex-generators": "^1.1.2",
2036
"vue": "^2.6.14",
@@ -23,5 +39,8 @@
2339
"devDependencies": {
2440
"@polar/lib-custom-types": "^1.0.0",
2541
"@polar/lib-test-mount-parameters": "^1.0.0"
42+
},
43+
"nx": {
44+
"includedScripts": ["bundle"]
2645
}
2746
}
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
import commonjs from '@rollup/plugin-commonjs'
2+
import resolve from '@rollup/plugin-node-resolve'
3+
import scss from 'rollup-plugin-scss'
4+
import svg from 'rollup-plugin-svg'
5+
import terser from '@rollup/plugin-terser'
6+
import typescript from 'rollup-plugin-typescript2'
7+
import vue from 'rollup-plugin-vue'
8+
9+
export default {
10+
input: 'src/index.ts',
11+
output: [
12+
{
13+
file: 'dist/index.js',
14+
name: '@polar/plugin-fullscreen',
15+
format: 'es',
16+
sourcemap: 'inline',
17+
},
18+
],
19+
external: ['@repositoryname/vuex-generators', 'vue', 'vuex'],
20+
plugins: [
21+
vue({
22+
defaultLang: { script: 'ts', style: 'scss' },
23+
css: false,
24+
}),
25+
scss({ fileName: 'index.css', sourceMap: true }),
26+
// Types are not checked as typechecking does not work for vue-files with the current version, might be fixable with an upgrade of vue and vuex; see https://github.com/vuejs/vuex/pull/1121.
27+
typescript({ check: false }),
28+
commonjs(),
29+
resolve(),
30+
svg(),
31+
terser(),
32+
],
33+
}
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
11
{
2-
"extends": "../../../tsconfig.json"
2+
"extends": "../../../tsconfig.json",
3+
"compilerOptions": {
4+
"outDir": "dist",
5+
},
6+
"include": [
7+
"src/**/*"
8+
]
39
}

0 commit comments

Comments
 (0)