Skip to content

AddressSearch, Pins, ReverseGeocoder: Reference hell #655

Description

@dopenguin

Describe the bug
The selected result of a successful search may be updated without the intent of the user.

This happens in a typical configuration that can be e.g. found in snowbox.
There, a selected search result sets a pin, which triggers a reverse geocoding. The result of that gets added to the addressSearch input.

This leads to two problems:

  • The user sometimes sees the loader for extended periods of time due to the unwanted reverse geocoding
  • The changed result may confuse users

Expected behavior
The selected result may only be updated if the user selects a result or sets a pin themselves.

Steps to reproduce

  1. Start snowbox
  2. Search for "Billstraße"
  3. Select "Billstraße"
  4. The result gets updated to "Billstraße 144"

Additional context
This problem also occurrs on main as far as I can tell and thus should be fixed on both branches.

It is also possible that other plugins may have such cyclic references. It may be reasonable to tackle this issue in a generalized scoped.

Metadata

Metadata

Labels

bugSomething isn't working

Type

Fields

No fields configured for Bug.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions