Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular-eslint/test-utils is added to dependencies, meaning plugin users need to install it #67

Closed
rubiesonthesky opened this issue Jan 24, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@rubiesonthesky
Copy link

Describe the bug

@angular-eslint/test-utils is added to dependencies in package.json when it's only used in the test for this plugin. It should be in devDependencies. See https://github.com/DaveMBush/eslint-plugin-rxjs/blob/main/packages/eslint-plugin-rxjs/package.json

Screenshots
If applicable, add screenshots to help explain your problem.

Repro
Version of @smarttools/eslint-plugin-rxjs you are using:

Repository that has a reproduction of the problem:

Note: providing a link to a reproduction of the problem will speed the resolution. It no only helps us see what the problem is and verify that it has been fixed, it helps us create a tests that we can run to verify no changes in the future bring the issue back.

Additional context

Thanks for creating this fork!

@rubiesonthesky
Copy link
Author

Also, if @typescript-eslint/rule-tester is only used in tests, it would be good to move it to devDependencies too.

@DaveMBush
Copy link
Owner

Thanks, I did this as part of #66

@github-project-automation github-project-automation bot moved this from New to Done in eslint-plugin-rxjs Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants