-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript Version of Noise Component in Animations Section #40
Comments
Hey! Just to note: I've modified how the code snippets work inside the project, now, we import the actual component files as raw text, so we can avoid duplicating the code: For example: import code from '@content/Animations/AnimatedContent/AnimatedContent.jsx?raw';
import tailwind from '@tailwind/Animations/AnimatedContent/AnimatedContent.jsx?raw';
import tsCode from '@ts-default/Animations/AnimatedContent/AnimatedContent.tsx?raw';
import tsTailwind from '@ts-tailwind/Animations/AnimatedContent/AnimatedContent.tsx?raw';
export const animatedContent = {
installation: `npm install @react-spring/web`,
cliDefault: `npx jsrepo add https://reactbits.dev/default/Animations/AnimatedContent`,
cliTailwind: `npx jsrepo add https://reactbits.dev/tailwind/Animations/AnimatedContent`,
cliTsDefault: `npx jsrepo add https://reactbits.dev/ts/default/Animations/AnimatedContent`,
cliTsTailwind: `npx jsrepo add https://reactbits.dev/ts/tailwind/Animations/AnimatedContent`,
usage: `import AnimatedContent from './AnimatedContent'
<AnimatedContent
distance={150}
direction="horizontal"
reverse={false}
config={{ tension: 80, friction: 20 }}
initialOpacity={0.2}
animateOpacity
scale={1.1}
threshold={0.2}
>
<div>Content to Animate</div>
</AnimatedContent>`,
code,
tailwind,
tsCode,
tsTailwind
} For components that also have CSS files, you would also add: import css from '@content/Animations/AnimatedContent/AnimatedContent.css?raw'; Only thing to note - it's important to keep the key naming as |
I will update this info in the general issue as well |
oh.. alright! should I start to work on it then? |
Yep, anytime you want |
hey @DavidHDev , should I create another branch(feat/add-ts-noise) for PR? or should I just put a request to directly merge into |
hey @whitedevil-glitch , after you have your fork, you can just open a PR with your changes. So you can merge your main into this repo's main. It's up to you if you prefer having separate branches |
Done, merged 👍 |
Description:
Hello!
I’d like to contribute by adding TypeScript support for the
Noise
component under theAnimations
section. As mentioned in issue #34, the library now supports TypeScript, and I’d like to help by converting this component to TypeScript.What I Plan to Do:
notes:
let me know if this is okay, and I’ll start working on it.
peace.
The text was updated successfully, but these errors were encountered: