Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit a0be662

Browse files
droyaddroyad
committed
Fixed reference to dbup-core and general post split cleanup
1 parent c9e3d4c commit a0be662

File tree

5 files changed

+85
-68
lines changed

5 files changed

+85
-68
lines changed

Diff for: ‎README.md

+23-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![GitHub Workflow Status (branch)](https://img.shields.io/github/workflow/status/DbUp/dbup-sqlce/CI/main)](https://github.com/DbUp/dbup-sqlce/actions/workflows/main.yml?query=branch%3Amain)
1+
[![GitHub Workflow Status (branch)](https://img.shields.io/github/actions/workflow/status/DbUp/dbup-sqlce/main.yml?branch=main)](https://github.com/DbUp/dbup-sqlce/actions/workflows/main.yml?query=branch%3Amain)
22
[![NuGet](https://img.shields.io/nuget/dt/dbup-sqlce.svg)](https://www.nuget.org/packages/dbup-sqlce)
33
[![NuGet](https://img.shields.io/nuget/v/dbup-sqlce.svg)](https://www.nuget.org/packages/dbup-sqlce)
44
[![Prerelease](https://img.shields.io/nuget/vpre/dbup-sqlce?color=orange&label=prerelease)](https://www.nuget.org/packages/dbup-sqlce)
@@ -18,4 +18,25 @@ our [main issue list](https://github.com/DbUp/DbUp/issues).
1818
# Contributing
1919

2020
See the [readme in our main repo](https://github.com/DbUp/DbUp/blob/master/README.md) for how to get started and
21-
contribute.
21+
contribute.
22+
23+
# Known Issues / Quirks
24+
25+
## Semi-colon Delimiter in multi statement scripts
26+
27+
The delimiter in a multi statement script should be on a new-line. I.e:
28+
29+
```sql
30+
ALTER TABLE "MyTable" ADD "foo" int default null
31+
;
32+
33+
ALTER TABLE "MyTable" ADD "bar" int default null
34+
;
35+
```
36+
37+
38+
## Development
39+
40+
For successful unit testing install
41+
42+
- SQL Server Compact 4.0 SP1 https://www.microsoft.com/en-us/download/details.aspx?id=30709

Diff for: ‎src/.editorconfig

+16-8
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ dotnet_style_prefer_conditional_expression_over_return = true:silent
4848
# Naming Conventions #
4949
###############################
5050
# Style Definitions
51-
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
51+
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
5252
# Use PascalCase for constant fields
5353
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
54-
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
55-
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
56-
dotnet_naming_symbols.constant_fields.applicable_kinds = field
57-
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
58-
dotnet_naming_symbols.constant_fields.required_modifiers = const
54+
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
55+
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
56+
dotnet_naming_symbols.constant_fields.applicable_kinds = field
57+
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
58+
dotnet_naming_symbols.constant_fields.required_modifiers = const
5959
###############################
6060
# C# Coding Conventions #
6161
###############################
@@ -78,7 +78,7 @@ csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
7878
csharp_style_throw_expression = true:suggestion
7979
csharp_style_conditional_delegate_call = true:suggestion
8080
# Modifier preferences
81-
csharp_preferred_modifier_order = public, private, protected, internal, static, extern, new, virtual, abstract, sealed, override, readonly, unsafe, volatile, async:suggestion
81+
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
8282
# Expression-level preferences
8383
csharp_prefer_braces = when_multiline:suggestion
8484
csharp_style_deconstructed_variable_declaration = true:suggestion
@@ -120,4 +120,12 @@ csharp_preserve_single_line_blocks = true
120120
###############################
121121
[*.vb]
122122
# Modifier preferences
123-
visual_basic_preferred_modifier_order = Partial, Default, Private, Protected, Public, Friend, NotOverridable, Overridable, MustOverride, Overloads, Overrides, MustInherit, NotInheritable, Static, Shared, Shadows, ReadOnly, WriteOnly, Dim, Const, WithEvents, Widening, Narrowing, Custom, Async:suggestion
123+
visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion
124+
###############################
125+
# XML and csproj #
126+
###############################
127+
[*.{xml,csproj}]
128+
max_line_length = off
129+
trim_trailing_whitespace = true
130+
insert_final_newline = true
131+
indent_size = 2

Diff for: ‎src/Tests/Tests.csproj

+24-24
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<PropertyGroup>
4-
<TargetFrameworks>net462</TargetFrameworks>
5-
<AssemblyName>Tests</AssemblyName>
6-
<RootNamespace>DbUp.SqlCe.Tests</RootNamespace>
7-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
8-
<!-- <ImplicitUsings>enable</ImplicitUsings> Can't use implict usings with net46 -->
9-
<Nullable>enable</Nullable>
10-
<NoWarn>$(NoWarn);NETSDK1138</NoWarn> <!-- Purposefully leaving an old version of netcoreapp to ensure we have compatibility. This never gets published -->
11-
<LangVersion>latest</LangVersion>
12-
</PropertyGroup>
3+
<PropertyGroup>
4+
<TargetFramework>net462</TargetFramework>
5+
<AssemblyName>Tests</AssemblyName>
6+
<RootNamespace>DbUp.SqlCe.Tests</RootNamespace>
7+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
8+
<!-- <ImplicitUsings>enable</ImplicitUsings> Can't use implict usings with net46 -->
9+
<Nullable>enable</Nullable>
10+
<NoWarn>$(NoWarn);NETSDK1138</NoWarn> <!-- Purposefully leaving an old version of netcoreapp to ensure we have compatibility. This never gets published -->
11+
<LangVersion>latest</LangVersion>
12+
</PropertyGroup>
1313

14-
<ItemGroup>
15-
<ProjectReference Include="..\dbup-sqlce\dbup-sqlce.csproj"/>
16-
<PackageReference Include="DbUp.Tests.Common" Version="5.0.37"/>
17-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
18-
<PackageReference Include="xunit" Version="2.6.6"/>
19-
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
20-
<PrivateAssets>all</PrivateAssets>
21-
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
22-
</PackageReference>
23-
</ItemGroup>
14+
<ItemGroup>
15+
<ProjectReference Include="..\dbup-sqlce\dbup-sqlce.csproj"/>
16+
<PackageReference Include="DbUp.Tests.Common" Version="5.0.37"/>
17+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
18+
<PackageReference Include="xunit" Version="2.6.6"/>
19+
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
20+
<PrivateAssets>all</PrivateAssets>
21+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
22+
</PackageReference>
23+
</ItemGroup>
2424

25-
<ItemGroup>
26-
<Compile Remove="ApprovalFiles\*.cs"/>
27-
<None Include="ApprovalFiles\*.cs"/>
28-
</ItemGroup>
25+
<ItemGroup>
26+
<Compile Remove="ApprovalFiles\*.cs"/>
27+
<None Include="ApprovalFiles\*.cs"/>
28+
</ItemGroup>
2929

3030
</Project>

Diff for: ‎src/dbup-sqlce/Properties/AssemblyInfo.cs

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
using System;
2-
using System.Reflection;
32
using System.Runtime.InteropServices;
43

5-
[assembly: AssemblyCompany("DbUp Contributors")]
6-
[assembly: AssemblyProduct("DbUp")]
7-
[assembly: AssemblyCopyright("Copyright © DbUp Contributors 2015")]
84
[assembly: ComVisible(false)]
95
[assembly: CLSCompliant(true)]
106

Diff for: ‎src/dbup-sqlce/dbup-sqlce.csproj

+22-30
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,28 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<PropertyGroup>
4-
<Description>DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds SQL CE Support.</Description>
5-
<Title>DbUp SQL CE Support</Title>
6-
<TargetFrameworks>net462</TargetFrameworks>
7-
<RootNamespace>DbUp.SqlCe</RootNamespace>
8-
<AssemblyOriginatorKeyFile>../dbup.snk</AssemblyOriginatorKeyFile>
9-
<SignAssembly>true</SignAssembly>
10-
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
11-
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
12-
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
13-
<RepositoryUrl>https://github.com/DbUp/dbup-sqlce.git</RepositoryUrl>
14-
<Product>dbup_sqlce</Product>
15-
<PackageId>dbup-sqlce</PackageId>
16-
<PackageIcon>dbup-icon.png</PackageIcon>
17-
</PropertyGroup>
3+
<PropertyGroup>
4+
<Description>DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds SQL CE Support.</Description>
5+
<Title>DbUp SQL CE Support</Title>
6+
<Company>DbUp Contributors</Company>
7+
<Product>DbUp</Product>
8+
<Copyright>Copyright © DbUp Contributors 2015</Copyright>
9+
<TargetFramework>net462</TargetFramework>
10+
<RootNamespace>DbUp.SqlCe</RootNamespace>
11+
<AssemblyOriginatorKeyFile>../dbup.snk</AssemblyOriginatorKeyFile>
12+
<SignAssembly>true</SignAssembly>
13+
<RepositoryUrl>https://github.com/DbUp/dbup-sqlce.git</RepositoryUrl>
14+
<Product>dbup_sqlce</Product>
15+
<PackageId>dbup-sqlce</PackageId>
16+
<PackageIcon>dbup-icon.png</PackageIcon>
17+
</PropertyGroup>
1818

19-
<ItemGroup>
20-
<PackageReference Include="dbup-core" Version="4.5.0"/>
21-
<PackageReference Include="Microsoft.SqlServer.Compact" Version="4.0.8876.1"/>
22-
</ItemGroup>
19+
<ItemGroup>
20+
<PackageReference Include="dbup-core" Version="5.0.37"/>
21+
<PackageReference Include="Microsoft.SqlServer.Compact" Version="4.0.8876.1"/>
22+
</ItemGroup>
2323

24-
<ItemGroup Condition="'$(TargetFramework)' == 'net35'">
25-
<PackageReference Include="Npgsql" Version="2.2.7"/> <!-- Last version that supports .NET 3.5 -->
26-
</ItemGroup>
27-
28-
<ItemGroup Condition="'$(TargetFramework)' != 'net35'">
29-
<PackageReference Include="Npgsql" Version="3.2.6"/>
30-
</ItemGroup>
31-
32-
<ItemGroup>
33-
<None Visible="false" Include="../dbup-icon.png" Pack="True" PackagePath=""/>
34-
</ItemGroup>
24+
<ItemGroup>
25+
<None Visible="false" Include="../dbup-icon.png" Pack="True" PackagePath=""/>
26+
</ItemGroup>
3527

3628
</Project>

0 commit comments

Comments
 (0)