Added CycleHelper

Author: DeGraciaMathieu

app/Presenter/Commands/Cyclic/Summary/CycleHelper.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace App\Presenter\Commands\Cyclic\Summary;
+
+use App\Presenter\Commands\Shared\NameFormatter;
+
+class CycleHelper
+{
+    public static function through(array $classNames): string
+    {
+        $readableNames = self::convertToReadableNames($classNames);
+
+        $path = self::joinWithArrows($readableNames);
+
+        return self::completeCircularPath($path, $classNames);
+    }
+
+    private static function convertToReadableNames(array $classNames): array
+    {
+        return array_map(function ($className) {
+            return NameFormatter::humanReadable($className);
+        }, $classNames);
+    }
+
+    private static function joinWithArrows(array $names): string
+    {
+        return implode(' -> ', $names);
+    }
+
+    private static function completeCircularPath(string $path, array $names): string
+    {
+        return $path . ' -> ' . NameFormatter::humanReadable($names[0]);
+    }
+}

app/Presenter/Commands/Cyclic/Summary/CyclicPresenterMapper.php

@@ -10,12 +10,15 @@ public static function from(array $cycles): array
     {
         return array_map(function (array $cycle) {
             return [
-                'start' => NameFormatter::humanReadable($cycle[0]),
-                'end' => NameFormatter::humanReadable(end($cycle)),
-                'through' => implode(' -> ', array_map(function($item) {
-                    return NameFormatter::className($item);
-                }, $cycle)) . ' -> ' . NameFormatter::className($cycle[0]),
+                'start' => self::humanReadable($cycle[0]),
+                'end' => self::humanReadable(end($cycle)),
+                'through' => CycleHelper::through($cycle),
             ];
         }, $cycles);
     }
+
+    private static function humanReadable(string $name): string
+    {
+        return NameFormatter::humanReadable($name);
+    }
 }

app/Presenter/Commands/Shared/NameFormatter.php

@@ -22,7 +22,7 @@ public static function humanReadable(string $className): string
 
         $exploded = self::keepLastTwoNamespaces($exploded);
 
-        return '...\\' . $exploded->implode('\\');
+        return '\\' . $exploded->implode('\\');
     }
 
     private static function isShortName(Collection $exploded): bool

tests/Unit/Formatters/NameFormatterTest.php

@@ -7,7 +7,7 @@
 });
 
 test('it formats human readable names', function () {
-    expect(NameFormatter::humanReadable('App\Domain\Services\CyclicDependency'))->toBe('...\\Services\\CyclicDependency');
+    expect(NameFormatter::humanReadable('App\Domain\Services\CyclicDependency'))->toBe('\\Services\\CyclicDependency');
 });
 
 test('it keeps short names', function () {

tests/Unit/Helpers/CycleHelperTest.php

@@ -0,0 +1,24 @@
+<?php
+
+use App\Presenter\Commands\Cyclic\Summary\CycleHelper;
+
+test('it formats a cycle', function () {
+
+    $cycle = ['A', 'B', 'C'];
+
+    $formatted = CycleHelper::through($cycle);
+
+    expect($formatted)->toBe('A -> B -> C -> A');
+});
+
+test('it formats a cycle with readable names', function () {
+
+    $cycle = [
+        'App\Domain\Services\BarService',
+        'App\Domain\Services\FooService',
+    ];
+
+    $formatted = CycleHelper::through($cycle);
+
+    expect($formatted)->toBe('\Services\BarService -> \Services\FooService -> \Services\BarService');
+});