fix abstractness calculation

DeGraciaMathieu · DeGraciaMathieu · commit 14e399d68484 · 2024-11-10T09:59:24.000+01:00
diff --git a/app/Presenter/Analyze/Summary/Calculators/AbstractnessCalculator.php b/app/Presenter/Analyze/Summary/Calculators/AbstractnessCalculator.php
@@ -8,11 +8,13 @@ class AbstractnessCalculator implements Calculator
 {
     public static function calculate(array $metric): string
     {
-        if ($metric['abstractness'] > 0.7) {
+        $ratio = $metric['abstractness']['ratio'];
+
+        if ($ratio > 0.7) {
             return 'abstract';
         }
 
-        if ($metric['abstractness'] < 0.3) {
+        if ($ratio < 0.3) {
             return 'concrete';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -8,11 +8,13 @@ class AbstractnessCalculator implements Calculator`
`8`	`8`	`{`
`9`	`9`	`public static function calculate(array $metric): string`
`10`	`10`	`{`
`11`		`- if ($metric['abstractness'] > 0.7) {`
	`11`	`+ $ratio = $metric['abstractness']['ratio'];`
	`12`	`+`
	`13`	`+ if ($ratio > 0.7) {`
`12`	`14`	`return 'abstract';`
`13`	`15`	`}`
`14`	`16`
`15`		`- if ($metric['abstractness'] < 0.3) {`
	`17`	`+ if ($ratio < 0.3) {`
`16`	`18`	`return 'concrete';`
`17`	`19`	`}`
`18`	`20`