From 6977ee964b0f4814fc315fb8c7fd68cbee1e7eba Mon Sep 17 00:00:00 2001 From: DeGraciaMathieu Date: Thu, 14 Nov 2024 22:36:01 +0100 Subject: [PATCH] Refacto MetricMapper --- app/Presenter/Analyze/Class/Shared/MetricMapper.php | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/app/Presenter/Analyze/Class/Shared/MetricMapper.php b/app/Presenter/Analyze/Class/Shared/MetricMapper.php index bdd9cd4..fb521cf 100644 --- a/app/Presenter/Analyze/Class/Shared/MetricMapper.php +++ b/app/Presenter/Analyze/Class/Shared/MetricMapper.php @@ -4,20 +4,13 @@ use App\Application\Analyze\AnalyzeMetric; -/** - * @todo : its work but it's not efficient - */ class MetricMapper { public function from(array $metrics): array { - $class = []; - - foreach ($metrics as $metric) { - $class[] = $this->makeClass($metric); - } - - return $class; + return array_map(function (AnalyzeMetric $metric) { + return $this->makeClass($metric); + }, $metrics); } private function makeClass(AnalyzeMetric $metric): Metric