Remove self dependencies from graph

Author: DeGraciaMathieu

app/Infrastructure/Graph/Adapters/Cytoscape/CytoscapeNetworkBuilder.php

@@ -5,6 +5,7 @@
 use App\Presenter\Analyze\Shared\Network\Network;
 use App\Presenter\Analyze\Shared\Network\NetworkBuilder;
 use App\Infrastructure\Graph\Adapters\Cytoscape\CytoscapeNetwork;
+use App\Presenter\Analyze\Shared\Network\NetworkAttribute;
 
 class CytoscapeNetworkBuilder implements NetworkBuilder
 {
@@ -33,6 +34,10 @@ private function mapEdges(array $metrics): void
 
             foreach ($item->dependencies() as $dependency) {
 
+                if ($this->isSelfDependency($dependency, $item)) {
+                    continue;
+                }
+
                 if ($this->network->missingNode($dependency)) {
                     $this->network->addNode($dependency);
                 }
@@ -41,4 +46,12 @@ private function mapEdges(array $metrics): void
             }
         }
     }
+
+    /**
+     * We remove self dependency from graph for readability reasons
+     */
+    private function isSelfDependency(string $dependency, NetworkAttribute $item): bool
+    {
+        return $dependency === $item->name();
+    }
 }