Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI "Listing parameters" twice #1018

Open
lionello opened this issue Feb 19, 2025 · 0 comments
Open

CLI "Listing parameters" twice #1018

lionello opened this issue Feb 19, 2025 · 0 comments
Labels
aws AWS related issue byoc Bring Your Own Cloud

Comments

@lionello
Copy link
Member

lionello commented Feb 19, 2025

During BYOC AWS deployment, --debug shows:

…
 - Listing parameters with prefix "/Defang/nounly/beta/"
 - Listing parameters with prefix "/Defang/nounly/beta/"
…

Once should be enough?

  • First one is in ComposeUp for ValidateProjectConfig to ensure any interpolated vars are in config
  • Second one is in FixupServices where we check whether an environment value is actually from config

We should combine these two.

@lionello lionello added aws AWS related issue byoc Bring Your Own Cloud labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws AWS related issue byoc Bring Your Own Cloud
Projects
None yet
Development

No branches or pull requests

1 participant