add new columns on categories page

DefiLlama · Dec 23, 2024 · 20d475e · 20d475e
1 parent e3424bf
commit 20d475e
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 41 deletions.
diff --git a/src/components/Table/Defi/columns.tsx b/src/components/Table/Defi/columns.tsx
@@ -176,24 +176,64 @@ export const categoriesColumn: ColumnDef<ICategoryRow>[] = [
 	{
 		header: 'Protocols',
 		accessorKey: 'protocols',
-		size: 100
+		size: 100,
+		meta: {
+			align: 'end'
+		}
 	},
 	{
 		header: 'Combined TVL',
 		accessorKey: 'tvl',
+		accessorFn: (row) => row.tvl ?? undefined,
 		cell: ({ getValue }) => {
 			const value = getValue() as number | null
 			return value && value > 0 ? <>{'$' + formattedNum(value)}</> : <></>
 		},
+		meta: {
+			align: 'end'
+		},
+		sortUndefined: 'last',
 		size: 135
 	},
+	{
+		header: '1d Change',
+		accessorKey: 'change_1d',
+		cell: (info) => <>{formattedPercent(info.getValue())}</>,
+		size: 110,
+		meta: {
+			align: 'end'
+		}
+	},
+	{
+		header: '7d Change',
+		accessorKey: 'change_7d',
+		cell: (info) => <>{formattedPercent(info.getValue())}</>,
+		size: 110,
+		meta: {
+			align: 'end'
+		}
+	},
+	{
+		header: '1m Change',
+		accessorKey: 'change_1m',
+		cell: (info) => <>{formattedPercent(info.getValue())}</>,
+		size: 110,
+		meta: {
+			align: 'end'
+		}
+	},
 	{
 		header: 'Combined 24h Revenue',
 		accessorKey: 'revenue',
+		accessorFn: (row) => row.revenue ?? undefined,
 		cell: ({ getValue }) => {
 			const value = getValue() as number | null
 			return value && value > 0 ? <>{'$' + formattedNum(value)}</> : <></>
 		},
+		meta: {
+			align: 'end'
+		},
+		sortUndefined: 'last',
 		size: 200
 	},
 	{

diff --git a/src/components/Table/Defi/types.ts b/src/components/Table/Defi/types.ts
@@ -18,6 +18,10 @@ export interface ICategoryRow {
 	protocols: number
 	tvl: number
 	description: string
+	change_1d: number
+	change_7d: number
+	change_1m: number
+	revenue: number
 }
 
 export interface IChain {

diff --git a/src/pages/categories.tsx b/src/pages/categories.tsx
@@ -9,6 +9,7 @@ import { categoriesColumn } from '~/components/Table/Defi/columns'
 import { TableWithSearch } from '~/components/Table/TableWithSearch'
 import { useCalcGroupExtraTvlsByDay } from '~/hooks/data'
 import Layout from '~/layout'
+import { getPercentChange } from '~/utils'
 import { withPerformanceLogging } from '~/utils/perf'
 
 const AreaChart = dynamic(() => import('~/components/ECharts/AreaChart'), {
@@ -57,9 +58,9 @@ export const getStaticProps = withPerformanceLogging('categories', async () => {
 			name,
 			protocols: details.protocols > 0 ? details.protocols : '',
 			tvl: details.tvl,
-			tvlPrevDay: details.tvlPrevDay ?? 0,
-			tvlPrevWeek: details.tvlPrevWeek ?? 0,
-			tvlPrevMonth: details.tvlPrevMonth ?? 0,
+			change_1d: getPercentChange(details.tvl, details.tvlPrevDay),
+			change_7d: getPercentChange(details.tvl, details.tvlPrevWeek),
+			change_1m: getPercentChange(details.tvl, details.tvlPrevMonth),
 			revenue: details.revenue,
 			description: descriptions[name] || ''
 		})
@@ -164,24 +165,6 @@ export const descriptions = {
 export default function Protocols({ categories, chartData, categoryColors, uniqueCategories }) {
 	const { chainsWithExtraTvlsByDay: categoriesWithExtraTvlsByDay } = useCalcGroupExtraTvlsByDay(chartData)
 
-	const [selectedValue, setValue] = React.useState('Current')
-
-	const finalCategories = React.useMemo(() => {
-		return selectedValue === 'Current'
-			? categories
-			: categories.map((category) => {
-					return {
-						...category,
-						tvl:
-							selectedValue === 'Prev Day'
-								? category.tvlPrevDay
-								: selectedValue === 'Prev Week'
-								? category.tvlPrevWeek
-								: category.tvlPrevMonth
-					}
-			  })
-	}, [categories, selectedValue])
-
 	return (
 		<Layout title={`Categories - DefiLlama`} defaultSEO>
 			<ProtocolsChainsSearch />
@@ -202,29 +185,11 @@ export default function Protocols({ categories, chartData, categoryColors, uniqu
 			</div>
 
 			<TableWithSearch
-				data={finalCategories}
+				data={categories}
 				columns={categoriesColumn}
 				columnToSearch={'name'}
 				placeholder={'Search category...'}
-				customFilters={
-					<div className="flex items-center rounded-lg overflow-x-auto flex-nowrap w-fit">
-						{values.map((value) => {
-							return (
-								<button
-									className="flex-shrink-0 py-2 px-3 whitespace-nowrap font-medium text-sm text-black dark:text-white bg-[var(--link-bg)] hover:bg-[var(--link-hover-bg)] focus-visible:bg-[var(--link-hover-bg)] data-[active=true]:bg-[var(--link-active-bg)] data-[active=true]:text-white"
-									data-active={value === selectedValue}
-									key={value}
-									onClick={() => setValue(value)}
-								>
-									{value}
-								</button>
-							)
-						})}
-					</div>
-				}
 			/>
 		</Layout>
 	)
 }
-
-const values = ['Current', 'Prev Day', 'Prev Week', 'Prev Month']