Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users CRUD #30

Closed
devincowan opened this issue Mar 2, 2023 · 3 comments · Fixed by #35
Closed

users CRUD #30

devincowan opened this issue Mar 2, 2023 · 3 comments · Fixed by #35

Comments

@devincowan
Copy link
Collaborator

UI for user Create, Edit, Deactivate

This was referenced Mar 7, 2023
@devincowan devincowan linked a pull request Mar 7, 2023 that will close this issue
@devincowan
Copy link
Collaborator Author

devincowan commented Mar 16, 2023

Making some notes here from our call today

  • We talked about having this check use $can instead of using auth in the main NAV bar
    https://github.com/DendraScience/dendra-web-ui/blob/dev-justin/src/components/MainNavigationDrawer.vue#L120

  • Users in their own separate "admin section" (we will add some other items to this as well) on the nav bar

  • Use the schema to lock down the ROLES to an array of 1 -- so we need to rename "ROLES" to "Role" on the user list page (added a card for this to our board todo for Scott)

  • API will not return any user that has a "higher" role than them (manager shouldn't be able to see sys_admin) (added a card for this to our board todo for Scott)

  • Add is_enabled filter for the users list page

  • Also add the ability to filter based on Role

  • The user list should show "preferred name" instead of "Full Name"

  • Fix the capitalization on labels (Preferred Name vs Preferred name, Roles, etc)

  • On the user edit page, if editing self, shouldn't be allowed to DEMOTE self from manager to user -- make the roles dropdown dynamic based on ability checks (maybe with an isSelf check?)

  • On the edit user page: we should be able to change the password -- password "reset"

  • For edit user page: it would be great to have password edit (ie "reset") --> it will be a button at the bottom of the user details page BUT WHEN THE PAGE IS NOT IN EDIT MODE -- > it will pop a separate dialog (created a separate issue for this todo for @ergjustin once Scott enables on the API)

  • On the new user CREATE page, there needs to be some re-ordering of the fields

@ergjustin
Copy link
Contributor

@jscottsf
Right now, if a manager needs to change user’s password, manager needs to have the current password of the user.
dendra-web-api

@devincowan
Copy link
Collaborator Author

Resolved via #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants