Skip to content

Commit 66890d4

Browse files
author
SarahOuologuem
committed
change function and parameter names
1 parent 775e334 commit 66890d4

File tree

5 files changed

+45
-45
lines changed

5 files changed

+45
-45
lines changed

panpipes/panpipes/pipeline_preprocess_spatial.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def gen_filter_jobs():
5252
@mkdir("tables")
5353
@mkdir("filtered.data")
5454
@files(gen_filter_jobs)
55-
def filter_mudata(infile_path,outfile):
55+
def filter_spatialdata(infile_path,outfile):
5656
print('processing file = %s' % str(infile_path))
5757
log_file = os.path.basename(outfile)
5858
log_file= "1_filtering."+log_file.replace("filtered.zarr","") + ".log"
@@ -61,15 +61,15 @@ def filter_mudata(infile_path,outfile):
6161
filter_dict = dictionary_stripper(PARAMS['filtering'])
6262
cmd = """
6363
python %(py_path)s/run_filter_spatial.py
64-
--input_mudata %(infile_path)s
65-
--output_mudata %(outfile)s
64+
--input_spatialdata %(infile_path)s
65+
--output_spatialdata %(outfile)s
6666
--filter_dict "%(filter_dict)s"
6767
"""
6868
if PARAMS['filtering_keep_barcodes'] is not None:
6969
cmd += " --keep_barcodes %(filtering_keep_barcodes)s"
7070
cmd += " > logs/%(log_file)s "
7171
job_kwargs["job_threads"] = PARAMS['resources_threads_low']
72-
log_msg = f"TASK: 'filter_mudata'" + f" IN CASE OF ERROR, PLEASE REFER TO : 'logs/{log_file}' FOR MORE INFORMATION."
72+
log_msg = f"TASK: 'filter_spatialdata'" + f" IN CASE OF ERROR, PLEASE REFER TO : 'logs/{log_file}' FOR MORE INFORMATION."
7373
get_logger().info(log_msg)
7474
P.run(cmd, **job_kwargs)
7575

@@ -84,7 +84,7 @@ def run_plotqc_query(pqc_dict):
8484

8585
@active_if(run_plotqc_query(PARAMS['plotqc']))
8686
@active_if(PARAMS['filtering_run'])
87-
@transform(filter_mudata,
87+
@transform(filter_spatialdata,
8888
regex("./filtered.data/(.*)_filtered.zarr"),
8989
r"./logs/2_postfilterplot.\1.log")
9090
def postfilterplot_spatial(filt_file,log_file):
@@ -93,7 +93,7 @@ def postfilterplot_spatial(filt_file,log_file):
9393
spatial_filetype = PARAMS["assay"]
9494
cmd = """
9595
python %(py_path)s/plot_qc_spatial.py
96-
--input_mudata %(filt_file)s
96+
--input_spatialdata %(filt_file)s
9797
--spatial_filetype %(spatial_filetype)s
9898
--figdir ./figures/spatial
9999
"""
@@ -108,7 +108,7 @@ def postfilterplot_spatial(filt_file,log_file):
108108
P.run(cmd, **job_kwargs)
109109

110110

111-
@transform(filter_mudata,
111+
@transform(filter_spatialdata,
112112
regex("./filtered.data/(.*)_filtered.zarr"),
113113
r"./logs/3_preprocess.\1.log")
114114
def spatial_preprocess(filt_file,log_file):
@@ -119,8 +119,8 @@ def spatial_preprocess(filt_file,log_file):
119119
write_output = os.path.join("./tmp/",os.path.basename(filt_file))
120120
cmd = """
121121
python %(py_path)s/run_preprocess_spatial.py
122-
--input_mudata %(filt_file)s
123-
--output_mudata %(write_output)s
122+
--input_spatialdata %(filt_file)s
123+
--output_spatialdata %(write_output)s
124124
--figdir ./figures/spatial
125125
"""
126126
if PARAMS['spatial_norm_hvg_flavour'] is not None:
@@ -154,7 +154,7 @@ def spatial_preprocess(filt_file,log_file):
154154
get_logger().info(log_msg)
155155
P.run(cmd, **job_kwargs)
156156

157-
@follows(filter_mudata, postfilterplot_spatial, spatial_preprocess)
157+
@follows(filter_spatialdata, postfilterplot_spatial, spatial_preprocess)
158158
@originate("cleanup_done.txt")
159159
def cleanup(file):
160160
# remove any ctmp fails

panpipes/panpipes/pipeline_qc_spatial.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def set_up_dirs(log_file):
5656
pass
5757

5858
# -----------------------------------------------------------------------------------------------
59-
## Creating h5mu from filtered data files
59+
## Creating spatialData from filtered data files
6060
# -----------------------------------------------------------------------------------------------
6161

6262

@@ -73,7 +73,7 @@ def gen_load_spatial_anndata_jobs():
7373
@follows(mkdir("logs"))
7474
@follows(mkdir("tmp"))
7575
@files(gen_load_spatial_anndata_jobs)
76-
def load_mudatas(spatial_path, outfile,
76+
def load_spatialdatas(spatial_path, outfile,
7777
sample_id, spatial_filetype, visium_feature_bc_matrix, visium_fullres_image_file, visium_tissue_positions_file, visium_scalefactors_file,
7878
vpt_cell_by_gene, vpt_cell_metadata, vpt_cell_boundaries):
7979

@@ -119,19 +119,19 @@ def load_mudatas(spatial_path, outfile,
119119
--vpt_cell_metadata %(vpt_cell_metadata)s
120120
--vpt_cell_boundaries %(vpt_cell_boundaries)s
121121
"""
122-
cmd += " > logs/1_make_mudatas_%(sample_id)s.log"
122+
cmd += " > logs/1_make_spatialdatas_%(sample_id)s.log"
123123
job_kwargs["job_threads"] = PARAMS['resources_threads_medium']
124-
log_msg = f"TASK: 'load_mudatas'" + f" IN CASE OF ERROR, PLEASE REFER TO : 'logs/1_make_mudatas_{sample_id}.log' FOR MORE INFORMATION."
124+
log_msg = f"TASK: 'load_spatialdatas'" + f" IN CASE OF ERROR, PLEASE REFER TO : 'logs/1_make_spatialdatas_{sample_id}.log' FOR MORE INFORMATION."
125125
get_logger().info(log_msg)
126126
P.run(cmd, **job_kwargs)
127127

128128

129129

130130

131-
@follows(load_mudatas)
131+
@follows(load_spatialdatas)
132132
@follows(mkdir("qc.data"))
133133
@follows(mkdir("./figures"))
134-
@transform(load_mudatas,
134+
@transform(load_spatialdatas,
135135
regex("./tmp/(.*)_raw.zarr"),
136136
r"./logs/2_spatialQC_\1.log")
137137
def spatialQC(infile,log_file):
@@ -179,7 +179,7 @@ def run_plotqc_query(pqc_dict):
179179
@follows(spatialQC)
180180
@follows(mkdir("./figures/spatial"))
181181
@active_if(run_plotqc_query(PARAMS['plotqc']))
182-
@transform(load_mudatas,
182+
@transform(load_spatialdatas,
183183
regex("./tmp/(.*)_raw.zarr"),
184184
r"./logs/3_qcplot.\1.log")
185185
def plotQC_spatial(unfilt_file,log_file):
@@ -188,7 +188,7 @@ def plotQC_spatial(unfilt_file,log_file):
188188
unfilt_file = unfilt_file.replace("tmp", "qc.data")
189189
cmd = """
190190
python %(py_path)s/plot_qc_spatial.py
191-
--input_mudata %(unfilt_file)s
191+
--input_spatialdata %(unfilt_file)s
192192
--spatial_filetype %(spatial_filetype)s
193193
--figdir ./figures/spatial
194194
"""

panpipes/python_scripts/plot_qc_spatial.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828

2929
parser = argparse.ArgumentParser()
3030

31-
parser.add_argument("--input_mudata",
32-
default="mudata_unfilt.h5mu",
31+
parser.add_argument("--input_spatialdata",
32+
default="spatialdata_unfilt.h5mu",
3333
help="")
3434
parser.add_argument("--figdir",
3535
default="./figures/",
@@ -58,12 +58,12 @@
5858
sc.settings.figdir = figdir
5959
sc.set_figure_params(scanpy=True, fontsize=14, dpi=300, facecolor='white', figsize=(5,5))
6060

61-
L.info("Reading in SpatialData from '%s'" % args.input_mudata)
62-
sdata = sd.read_zarr(args.input_mudata)
63-
#mdata = mu.read(args.input_mudata)
61+
L.info("Reading in SpatialData from '%s'" % args.input_spatialdata)
62+
sdata = sd.read_zarr(args.input_spatialdata)
63+
#mdata = mu.read(args.input_spatialdata)
6464
#spatial = mdata.mod['spatial']
6565

66-
input_data = os.path.basename(args.input_mudata)
66+
input_data = os.path.basename(args.input_spatialdata)
6767
pattern = r"_filtered.zarr"
6868
match = re.search(pattern, input_data)
6969
if match is None:

panpipes/python_scripts/run_filter_spatial.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,18 @@ def test_matching_df_ignore_cat(new_df, old_df):
4242
# parse arguments
4343
parser = argparse.ArgumentParser()
4444

45-
parser.add_argument('--input_mudata',
45+
parser.add_argument('--input_spatialdata',
4646
default='gut_minus1_amp.h5ad',
4747
help='')
48-
parser.add_argument('--output_mudata',
48+
parser.add_argument('--output_spatialdata',
4949
default='',
5050
help='')
5151
parser.add_argument('--filter_dict',
5252
default='',
5353
help='this is pull')
5454
# cross modalities args
5555
parser.add_argument('--keep_barcodes', default=None,
56-
help='1 column list of barcodes to keep, note that they should match the mudata input, this filtering happens first')
56+
help='1 column list of barcodes to keep, note that they should match the spatialdata input, this filtering happens first')
5757

5858

5959
# load options
@@ -73,14 +73,14 @@ def test_matching_df_ignore_cat(new_df, old_df):
7373
filter_dict = dictionary_stripper(filter_dict)
7474
L.info("Filter dictionary:\n %s" %filter_dict)
7575

76-
# load mudata
76+
# load spatialdata
7777

78-
L.info("Reading in SpatialData from '%s'" % args.input_mudata)
79-
sdata = sd.read_zarr(args.input_mudata)
80-
#mdata = mu.read(args.input_mudata)
78+
L.info("Reading in SpatialData from '%s'" % args.input_spatialdata)
79+
sdata = sd.read_zarr(args.input_spatialdata)
80+
#mdata = mu.read(args.input_spatialdata)
8181

8282
#if isinstance(mdata, AnnData):
83-
# raise TypeError("Input '%s' should be of MuData format, not Anndata" % args.input_mudata)
83+
# raise TypeError("Input '%s' should be of spatialdata format, not Anndata" % args.input_spatialdata)
8484

8585
orig_obs = sdata["table"].obs.copy()
8686

@@ -147,7 +147,7 @@ def test_matching_df_ignore_cat(new_df, old_df):
147147
assert test_matching_df_ignore_cat(sdata["table"].obs, orig_obs)
148148

149149
# write out obs
150-
output_prefix = re.sub(".zarr", "", os.path.basename(args.output_mudata))
150+
output_prefix = re.sub(".zarr", "", os.path.basename(args.output_spatialdata))
151151

152152
L.info("Saving updated obs in a metadata tsv file to './tables/" + output_prefix + "_filtered_cell_metadata.tsv'")
153153
write_obs(sdata["table"], output_prefix=os.path.join("tables/",output_prefix), output_suffix="_filtered_cell_metadata.tsv")
@@ -166,8 +166,8 @@ def test_matching_df_ignore_cat(new_df, old_df):
166166

167167
#mdata.update()
168168

169-
L.info("Saving updated SpatialData to '%s'" % args.output_mudata)
170-
sdata.write(args.output_mudata)
169+
L.info("Saving updated SpatialData to '%s'" % args.output_spatialdata)
170+
sdata.write(args.output_spatialdata)
171171

172172
L.info("Done")
173173

panpipes/python_scripts/run_preprocess_spatial.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@
3232

3333
parser = argparse.ArgumentParser()
3434

35-
parser.add_argument("--input_mudata",
36-
default="mudata_unfilt.h5mu",
35+
parser.add_argument("--input_spatialdata",
36+
default="spatialdata_unfilt.h5mu",
3737
help="")
38-
parser.add_argument("--output_mudata",
39-
default="mudata_unfilt.h5mu",
38+
parser.add_argument("--output_spatialdata",
39+
default="spatialdata_unfilt.h5mu",
4040
help="")
4141
parser.add_argument("--figdir",
4242
default="./figures/",
@@ -89,12 +89,12 @@
8989
sc.settings.figdir = figdir
9090
sc.set_figure_params(scanpy=True, fontsize=14, dpi=300, facecolor='white', figsize=(5,5))
9191

92-
L.info("Reading in SpatialData from '%s'" % args.input_mudata)
93-
sdata = sd.read_zarr(args.input_mudata)
94-
#mdata = mu.read(args.input_mudata)
92+
L.info("Reading in SpatialData from '%s'" % args.input_spatialdata)
93+
sdata = sd.read_zarr(args.input_spatialdata)
94+
#mdata = mu.read(args.input_spatialdata)
9595
#spatial = mdata.mod['spatial']
9696

97-
input_data = os.path.basename(args.input_mudata)
97+
input_data = os.path.basename(args.input_spatialdata)
9898
pattern = r"_filtered.zarr"
9999
match = re.search(pattern, input_data)
100100
sprefix = input_data[:match.start()]
@@ -174,8 +174,8 @@
174174

175175

176176
#mdata.update()
177-
L.info("Saving updated SpatialData to '%s'" % args.output_mudata)
178-
sdata.write(args.output_mudata)
177+
L.info("Saving updated SpatialData to '%s'" % args.output_spatialdata)
178+
sdata.write(args.output_spatialdata)
179179

180180
L.info("Done")
181181

0 commit comments

Comments
 (0)