Merge pull request amitshekhariitbhu#32 from MilkBiscuit/master

Optimise time complexity of filterUserWhoLovesBoth

Author: amitshekhariitbhu

app/src/main/java/com/rxjava2/android/samples/model/User.java

@@ -27,4 +27,22 @@ public String toString() {
                 ", isFollowing=" + isFollowing +
                 '}';
     }
+
+    @Override
+    public int hashCode() {
+        return (int) id + firstname.hashCode() + lastname.hashCode();
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (obj instanceof User) {
+            User user = (User) obj;
+
+            return this.id == user.id
+                    && this.firstname.equals(user.firstname)
+                    && this.lastname.equals(user.lastname);
+        }
+
+        return false;
+    }
 }

app/src/main/java/com/rxjava2/android/samples/ui/networking/NetworkingActivity.java

@@ -152,13 +152,13 @@ public void onComplete() {
 
     private List<User> filterUserWhoLovesBoth(List<User> cricketFans, List<User> footballFans) {
         List<User> userWhoLovesBoth = new ArrayList<>();
-        for (User cricketFan : cricketFans) {
-            for (User footballFan : footballFans) {
-                if (cricketFan.id == footballFan.id) {
-                    userWhoLovesBoth.add(cricketFan);
-                }
+
+        for (User footballFan : footballFans) {
+            if (cricketFans.contains(footballFan)) {
+                userWhoLovesBoth.add(footballFan);
             }
         }
+
         return userWhoLovesBoth;
     }