Skip to content

Commit 1550731

Browse files
Cjkjvfnbygithub-actions
and
github-actions
authored
Remove file-level flake8 suppression (TheAlgorithms#7844)
* Remove file-level flake8 suppression * updating DIRECTORY.md * Fix tests Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
1 parent 47ddba1 commit 1550731

File tree

4 files changed

+34
-36
lines changed

4 files changed

+34
-36
lines changed

DIRECTORY.md

+2
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,7 @@
671671

672672
## Physics
673673
* [Casimir Effect](physics/casimir_effect.py)
674+
* [Centripetal Force](physics/centripetal_force.py)
674675
* [Horizontal Projectile Motion](physics/horizontal_projectile_motion.py)
675676
* [Kinetic Energy](physics/kinetic_energy.py)
676677
* [Lorentz Transformation Four Vector](physics/lorentz_transformation_four_vector.py)
@@ -1069,6 +1070,7 @@
10691070
* [Is Palindrome](strings/is_palindrome.py)
10701071
* [Is Pangram](strings/is_pangram.py)
10711072
* [Is Spain National Id](strings/is_spain_national_id.py)
1073+
* [Is Srilankan Phone Number](strings/is_srilankan_phone_number.py)
10721074
* [Jaro Winkler](strings/jaro_winkler.py)
10731075
* [Join](strings/join.py)
10741076
* [Knuth Morris Pratt](strings/knuth_morris_pratt.py)

data_structures/heap/binomial_heap.py

+25-25
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# flake8: noqa
2-
31
"""
42
Binomial Heap
53
Reference: Advanced Data Structures, Peter Brass
@@ -22,7 +20,7 @@ def __init__(self, val):
2220
self.right = None
2321
self.parent = None
2422

25-
def mergeTrees(self, other):
23+
def merge_trees(self, other):
2624
"""
2725
In-place merge of two binomial trees of equal size.
2826
Returns the root of the resulting tree
@@ -75,9 +73,8 @@ class BinomialHeap:
7573
30
7674
7775
Deleting - delete() test
78-
>>> for i in range(25):
79-
... print(first_heap.deleteMin(), end=" ")
80-
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24
76+
>>> [first_heap.delete_min() for _ in range(20)]
77+
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]
8178
8279
Create a new Heap
8380
>>> second_heap = BinomialHeap()
@@ -97,8 +94,8 @@ class BinomialHeap:
9794
# # # #
9895
9996
preOrder() test
100-
>>> second_heap.preOrder()
101-
[(17, 0), ('#', 1), (31, 1), (20, 2), ('#', 3), ('#', 3), (34, 2), ('#', 3), ('#', 3)]
97+
>>> " ".join(str(x) for x in second_heap.pre_order())
98+
"(17, 0) ('#', 1) (31, 1) (20, 2) ('#', 3) ('#', 3) (34, 2) ('#', 3) ('#', 3)"
10299
103100
printing Heap - __str__() test
104101
>>> print(second_heap)
@@ -113,22 +110,25 @@ class BinomialHeap:
113110
---#
114111
115112
mergeHeaps() test
116-
>>> merged = second_heap.mergeHeaps(first_heap)
113+
>>>
114+
>>> merged = second_heap.merge_heaps(first_heap)
117115
>>> merged.peek()
118116
17
119117
120118
values in merged heap; (merge is inplace)
121-
>>> while not first_heap.isEmpty():
122-
... print(first_heap.deleteMin(), end=" ")
123-
17 20 25 26 27 28 29 31 34
119+
>>> results = []
120+
>>> while not first_heap.is_empty():
121+
... results.append(first_heap.delete_min())
122+
>>> results
123+
[17, 20, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 31, 34]
124124
"""
125125

126126
def __init__(self, bottom_root=None, min_node=None, heap_size=0):
127127
self.size = heap_size
128128
self.bottom_root = bottom_root
129129
self.min_node = min_node
130130

131-
def mergeHeaps(self, other):
131+
def merge_heaps(self, other):
132132
"""
133133
In-place merge of two binomial heaps.
134134
Both of them become the resulting merged heap
@@ -180,7 +180,7 @@ def mergeHeaps(self, other):
180180
next_node = i.parent.parent
181181

182182
# Merging trees
183-
i = i.mergeTrees(i.parent)
183+
i = i.merge_trees(i.parent)
184184

185185
# Updating links
186186
i.left = previous_node
@@ -238,7 +238,7 @@ def insert(self, val):
238238
next_node = self.bottom_root.parent.parent
239239

240240
# Merge
241-
self.bottom_root = self.bottom_root.mergeTrees(self.bottom_root.parent)
241+
self.bottom_root = self.bottom_root.merge_trees(self.bottom_root.parent)
242242

243243
# Update Links
244244
self.bottom_root.parent = next_node
@@ -252,10 +252,10 @@ def peek(self):
252252
"""
253253
return self.min_node.val
254254

255-
def isEmpty(self):
255+
def is_empty(self):
256256
return self.size == 0
257257

258-
def deleteMin(self):
258+
def delete_min(self):
259259
"""
260260
delete min element and return it
261261
"""
@@ -317,7 +317,7 @@ def deleteMin(self):
317317
return min_value
318318
# Remaining cases
319319
# Construct heap of right subtree
320-
newHeap = BinomialHeap(
320+
new_heap = BinomialHeap(
321321
bottom_root=bottom_of_new, min_node=min_of_new, heap_size=size_of_new
322322
)
323323

@@ -354,11 +354,11 @@ def deleteMin(self):
354354
self.min_node = i
355355
i = i.parent
356356
# Merge heaps
357-
self.mergeHeaps(newHeap)
357+
self.merge_heaps(new_heap)
358358

359359
return min_value
360360

361-
def preOrder(self):
361+
def pre_order(self):
362362
"""
363363
Returns the Pre-order representation of the heap including
364364
values of nodes plus their level distance from the root;
@@ -369,9 +369,9 @@ def preOrder(self):
369369
while top_root.parent:
370370
top_root = top_root.parent
371371
# preorder
372-
heap_preOrder = []
373-
self.__traversal(top_root, heap_preOrder)
374-
return heap_preOrder
372+
heap_pre_order = []
373+
self.__traversal(top_root, heap_pre_order)
374+
return heap_pre_order
375375

376376
def __traversal(self, curr_node, preorder, level=0):
377377
"""
@@ -389,9 +389,9 @@ def __str__(self):
389389
Overwriting str for a pre-order print of nodes in heap;
390390
Performance is poor, so use only for small examples
391391
"""
392-
if self.isEmpty():
392+
if self.is_empty():
393393
return ""
394-
preorder_heap = self.preOrder()
394+
preorder_heap = self.pre_order()
395395

396396
return "\n".join(("-" * level + str(value)) for value, level in preorder_heap)
397397

other/activity_selection.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# flake8: noqa
2-
31
"""The following implementation assumes that the activities
42
are already sorted according to their finish time"""
53

@@ -10,11 +8,11 @@
108
# finish[] --> An array that contains finish time of all activities
119

1210

13-
def printMaxActivities(start: list[int], finish: list[int]) -> None:
11+
def print_max_activities(start: list[int], finish: list[int]) -> None:
1412
"""
1513
>>> start = [1, 3, 0, 5, 8, 5]
1614
>>> finish = [2, 4, 6, 7, 9, 9]
17-
>>> printMaxActivities(start, finish)
15+
>>> print_max_activities(start, finish)
1816
The following activities are selected:
1917
0,1,3,4,
2018
"""
@@ -43,4 +41,4 @@ def printMaxActivities(start: list[int], finish: list[int]) -> None:
4341

4442
start = [1, 3, 0, 5, 8, 5]
4543
finish = [2, 4, 6, 7, 9, 9]
46-
printMaxActivities(start, finish)
44+
print_max_activities(start, finish)

searches/binary_tree_traversal.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# flake8: noqa
2-
31
"""
42
This is pure Python implementation of tree traversal algorithms
53
"""
@@ -157,16 +155,16 @@ def level_order_actual(node: TreeNode) -> None:
157155
q: queue.Queue = queue.Queue()
158156
q.put(node)
159157
while not q.empty():
160-
list = []
158+
list_ = []
161159
while not q.empty():
162160
node_dequeued = q.get()
163161
print(node_dequeued.data, end=",")
164162
if node_dequeued.left:
165-
list.append(node_dequeued.left)
163+
list_.append(node_dequeued.left)
166164
if node_dequeued.right:
167-
list.append(node_dequeued.right)
165+
list_.append(node_dequeued.right)
168166
print()
169-
for node in list:
167+
for node in list_:
170168
q.put(node)
171169

172170

0 commit comments

Comments
 (0)