Throw error if DELETE_FAILED_DEVICE_POLICY_MANAGER is sent (#513)

Signed-off-by: Burak Demir <[email protected]>

Author: tburakdemir

src/adb/command/host-transport/uninstall.ts

@@ -2,6 +2,11 @@ import Protocol from '../../protocol';
 import Command from '../../command';
 import Bluebird from 'bluebird';
 
+class UninstallError extends Error {
+  constructor(message: string) {
+    super(message);
+  }
+}
 export default class UninstallCommand extends Command<boolean> {
   execute(pkg: string): Bluebird<boolean> {
     this._send(`shell:pm uninstall ${pkg}`);
@@ -13,6 +18,9 @@ export default class UninstallCommand extends Command<boolean> {
             .then(function (match) {
               if (match[1] === 'Success') {
                 return true;
+              } else if (match[1].includes('DELETE_FAILED_DEVICE_POLICY_MANAGER')) {
+                const reason = match[1];
+                throw new UninstallError(`${pkg} could not be uninstalled [${reason}]`);
               } else {
                 // Either way, the package was uninstalled or doesn't exist,
                 // which is good enough for us.

test/adb/command/host-transport/uninstall.ts

@@ -33,6 +33,22 @@ describe('UninstallCommand', function () {
         });
         return cmd.execute('foo');
     });
+    it("should failed if command responds with 'Failure [DELETE_FAILED_DEVICE_POLICY_MANAGER]'", function (done) {
+        const conn = new MockConnection();
+        const cmd = new UninstallCommand(conn);
+        conn.getSocket().on('write', function (chunk) {
+            return expect(chunk.toString()).to.equal(Protocol.encodeData('shell:pm uninstall foo').toString());
+        });
+        setImmediate(function () {
+            conn.getSocket().causeRead(Protocol.OKAY);
+            conn.getSocket().causeRead('Failure [DELETE_FAILED_DEVICE_POLICY_MANAGER]\r\n');
+            return conn.getSocket().causeEnd();
+        });
+        cmd.execute('foo').catch(function (err) {
+            expect(err.message).includes('Failure [DELETE_FAILED_DEVICE_POLICY_MANAGER]');
+            done();
+        });
+    });
     it("should succeed even if command responds with 'Failure' with info in standard format", function () {
         const conn = new MockConnection();
         const cmd = new UninstallCommand(conn);