Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code inconsistencies and potential minor bugs #3

Open
12 tasks done
akadlof opened this issue Jan 28, 2025 · 1 comment
Open
12 tasks done

Some code inconsistencies and potential minor bugs #3

akadlof opened this issue Jan 28, 2025 · 1 comment
Assignees

Comments

@akadlof
Copy link
Collaborator

akadlof commented Jan 28, 2025

Found a few minor issues in the code. Consider the use of a linter to automatically detect some of these.

  • dates variable in new_collection function in storm_catalog.py can technically be used before assignment which would result in a crash
  • string interpolation mistakes (storm_catalog.py line 558)
  • use of open without specifying encoding
  • use of built-in names like id and callable (storm_catalog.py line 204, transpose.py line 238)
  • use of == None instead of is None
  • consider using exception re-raising
  • assignment of function with no return to variable
  • missing docstrings
  • unused variables
  • unused imports
  • missing parameter or return types
  • consider using lazy formatting of logging strings to increase performance
@slawler
Copy link
Member

slawler commented Jan 29, 2025

Thanks @akadlof, updated these to be a checklist.

@sray can you please help address these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants