Fixed lint errors. Configured landscape

Author: DheerendraRathor

.landscape.yml

@@ -0,0 +1,11 @@
+test-warnings: no
+strictness: veryhigh
+max-line-length: 120
+uses:
+  - django
+
+pylint:
+  disable:
+    - star-args
+    - too-few-public-methods
+    - too-many-ancestors

account/forms.py

@@ -1,5 +1,3 @@
-__author__ = 'dheerendra'
-
 from django import forms
 
 
@@ -45,4 +43,4 @@ class LoginForm(forms.Form):
             }
         ),
         required=False
-    )
+    )

account/models.py

@@ -3,6 +3,7 @@
 import os
 from uuid import uuid4
 
+
 def user_profile_picture(instance, filename):
     filename = filename.split('.')
     if len(filename) > 1:

account/urls.py

@@ -1,9 +1,7 @@
-__author__ = 'dheerendra'
-
 from django.conf.urls import url
 from .views import LoginView, LogoutView
 
 urlpatterns = [
     url(r'^login/$', LoginView.as_view(), name="login"),
     url(r'^logout/$', LogoutView.as_view(), name='logout'),
-]
+]

application/forms.py

@@ -9,8 +9,8 @@ class RegistrationForm(forms.ModelForm):
     class Meta:
         model = Application
         fields = (
-            'name', 'description', 'logo', 'website', 'privacy_policy', 'client_id', 'client_secret', 'client_type', 'authorization_grant_type',
-            'redirect_uris')
+            'name', 'description', 'logo', 'website', 'privacy_policy', 'client_id', 'client_secret', 'client_type',
+            'authorization_grant_type', 'redirect_uris')
         widgets = {
             'description': forms.Textarea(
                 attrs={'class': 'form-control', 'rows': 3, }

application/templatetags/scope.py

@@ -1,13 +1,18 @@
 from django import template
-from django.conf import settings
 from core.utils import get_default_scopes
 
 register = template.Library()
 
 
 @register.filter(name='zip')
-def zip_list(a, b):
-    return list(zip(a, b))
+def zip_list(lis1, lis2):
+    """
+    Template tag to zip 2 lists
+    :param lis1: First List
+    :param lis2: Second List
+    :return: Zipped lists
+    """
+    return zip(lis1, lis2)
 
 
 @register.filter(name='get_basic_scope')

application/urls.py

@@ -1,7 +1,4 @@
-__author__ = 'dheerendra'
-
-from django.conf.urls import include, url
-import oauth2_provider.urls
+from django.conf.urls import url
 from views import ApplicationRegistrationView, ApplicationUpdateView, CustomAuthorizationView
 
 urlpatterns = [

application/validators.py

@@ -24,9 +24,8 @@ def save_bearer_token(self, token, request, *args, **kwargs):
         It's messy. It is 90% code from parent function. I didn't find a way to reduce it.
         I tried and I failed :'(
         Sin Count += 1
-        """
 
-        """
+
         Save access and refresh token, If refresh token is issued, remove old refresh tokens as
         in rfc:`6`
         """

core/notification.py

@@ -38,4 +38,4 @@ def open(self):
             return True
         except smtplib.SMTPException:
             if not self.fail_silently:
-                raise
+                raise

core/templatetags/absolute_url.py

@@ -6,4 +6,4 @@
 @register.simple_tag(takes_context=True)
 def absolute_url(context, location):
     request = context['request']
-    return request.build_absolute_uri(location)
+    return request.build_absolute_uri(location)

core/templatetags/model_media.py

@@ -12,4 +12,4 @@ def model_field_media_url(field):
         url = urljoin(settings.MEDIA_URL, url)
     except ValueError:
         url = None
-    return url
+    return url

core/utils.py

@@ -4,4 +4,4 @@
 def get_default_scopes(application):
     if application.is_anonymous:
         return application.required_scopes.split()
-    return settings.OAUTH2_DEFAULT_SCOPES
+    return settings.OAUTH2_DEFAULT_SCOPES

gunicorn_conf.py

@@ -1,13 +1,13 @@
-"""gunicorn WSGI server configuration."""
+# pylint: disable=invalid-name
 from multiprocessing import cpu_count
 
 
-def max_workers():    
+def max_workers():
     return 2 * cpu_count() + 1
 
 
 workers = max_workers()
 worker_class = 'gevent'
 accesslog = "logs/gunicorn_access.log"
 access_log_format = "%(h)s %({X-Real-IP}i)s %(D)s %(l)s %(u)s %(t)s %(r)s %(s)s %(b)s %(f)s %(a)s"
-errorlog = "logs/gunicorn_error.log"
+errorlog = "logs/gunicorn_error.log"

sso/settings.py

@@ -267,4 +267,4 @@
 }
 logging.config.dictConfig(LOGGING)
 
-from settings_user import *
+from settings_user import *  # noqa

sso/urls.py

@@ -42,12 +42,12 @@
 urlpatterns += [
     url(r'^%s(?P<path>.*)$' % re.escape(settings.STATIC_URL.lstrip('/')), serve,
         kwargs={
-            'document_root': settings.STATIC_ROOT
+            'document_root': settings.STATIC_ROOT,
         }
         ),
     url(r'^%s(?P<path>.*)$' % re.escape(settings.MEDIA_URL.lstrip('/')), serve,
         kwargs={
-            'document_root': settings.MEDIA_ROOT
+            'document_root': settings.MEDIA_ROOT,
         }
         ),
 ]

user_resource/forms.py

@@ -8,15 +8,15 @@ class ProfilePictureForm(forms.Form):
     profile_picture = forms.ImageField()
 
     def clean_profile_picture(self):
-        pp = self.cleaned_data['profile_picture']
-        content_type = pp.content_type.split('/')[0]
+        profile_picture = self.cleaned_data['profile_picture']
+        content_type = profile_picture.content_type.split('/')[0]
         if content_type in ['image']:
-            if pp._size > 5242880:
+            if profile_picture.size > 5242880:
                 raise forms.ValidationError(_('Please keep filesize under %s. Current filesize %s') % (
-                filesizeformat(5242880), filesizeformat(pp._size)))
+                    filesizeformat(5242880), filesizeformat(profile_picture.size)))
         else:
             raise forms.ValidationError(_('File type is not supported'))
-        return pp
+        return profile_picture
 
 
 class InstituteAddressForm(forms.ModelForm):

user_resource/models.py

@@ -103,4 +103,4 @@ class SentMessage(models.Model):
     user = models.ForeignKey(User)
     status = models.BooleanField(default=True)
     error_message = models.TextField(null=True, blank=True)
-    created = models.DateTimeField(auto_now_add=True)
+    created = models.DateTimeField(auto_now_add=True)

user_resource/oauth.py

@@ -1,5 +1,5 @@
-default_fields = ['id', ]
-user_fields = [
+DEFAULT_FIELDS = ['id', ]
+USER_FIELDS = [
     'username',
     'first_name',
     'last_name',
@@ -13,7 +13,7 @@
     'roll_number',
 ]
 
-scope_to_field_map = {
+SCOPE_TO_FIELD_MAP = {
     'basic': ['id', ],
     'profile': ['first_name', 'last_name'],
     'picture': ['profile_picture'],

user_resource/serializers.py

@@ -2,7 +2,7 @@
 from .models import Program, ContactNumber, SecondaryEmail, InstituteAddress
 from django.contrib.auth.models import User
 import copy
-from .oauth import default_fields, user_fields
+from .oauth import DEFAULT_FIELDS, USER_FIELDS
 
 
 class ProgramSerializer(serializers.ModelSerializer):
@@ -44,7 +44,7 @@ def __init__(self, *args, **kwargs):
         fields = self.context.get('fields')
         if not isinstance(fields, list) and not isinstance(fields, set):
             fields = []
-        fields.extend(default_fields)
+        fields.extend(DEFAULT_FIELDS)
 
         if fields is not None:
             allowed = set(fields)
@@ -55,7 +55,7 @@ def __init__(self, *args, **kwargs):
 
     class Meta:
         model = User
-        fields = copy.deepcopy(default_fields).extend(user_fields)
+        fields = copy.deepcopy(DEFAULT_FIELDS).extend(USER_FIELDS)
 
 
 class SendMailSerializer(serializers.Serializer):

user_resource/views/api.py

@@ -10,7 +10,7 @@
 from django.core.mail import EmailMessage
 
 from ..serializers import UserSerializer, SendMailSerializer
-from ..oauth import scope_to_field_map, default_fields, user_fields
+from ..oauth import SCOPE_TO_FIELD_MAP, DEFAULT_FIELDS, USER_FIELDS
 from ..models import SentMessage
 
 logger = logging.getLogger(__name__)
@@ -33,15 +33,15 @@ def list(self, request):
         granted_scopes = granted_scopes.split()
         granted_fields = []
         for scope in granted_scopes:
-            granted_fields.extend(scope_to_field_map[scope])
+            granted_fields.extend(SCOPE_TO_FIELD_MAP[scope])
 
         if fields is None:
             fields = []
         else:
             fields = fields.split(',')
             fields = [field.strip() for field in fields if field.strip()]
         fields = set(fields)
-        all_fields = set(default_fields + user_fields)
+        all_fields = set(DEFAULT_FIELDS + USER_FIELDS)
         undefined_fields = list(fields - all_fields)
         if undefined_fields:
             error_message = {
@@ -89,10 +89,10 @@ def send_mail(self, request):
                 email_message.send()
                 sent_message.status = True
                 response_data['status'] = True
-            except SMTPException as e:
+            except SMTPException as err:
                 sent_message.status = False,
-                sent_message.error_message = e.message
-                logger.error(e)
+                sent_message.error_message = err.message
+                logger.error(err)
                 response_data['status'] = False
             sent_message.save()
             return Response(response_data)

user_resource/views/home.py

@@ -84,9 +84,9 @@ class UpdateUserProfilePicture(LoginRequiredMixin, View):
     def post(self, request):
         pp_form = ProfilePictureForm(request.POST, request.FILES)
         if pp_form.is_valid():
-            pp = pp_form.cleaned_data['profile_picture']
+            profile_picture = pp_form.cleaned_data['profile_picture']
             userprofile = request.user.userprofile
-            userprofile.profile_picture = pp
+            userprofile.profile_picture = profile_picture
             userprofile.save()
             response = {'url': userprofile.profile_picture.url}
             return HttpResponse(json.dumps(response))

widget/urls.py

@@ -4,4 +4,4 @@
 
 urlpatterns = [
     url(r'login/$', LoginWidget.as_view(), name='login'),
-]
+]