Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail confusingly without XDS #55

Open
ndevenish opened this issue Aug 24, 2023 · 0 comments · May be fixed by #58
Open

Tests fail confusingly without XDS #55

ndevenish opened this issue Aug 24, 2023 · 0 comments · May be fixed by #58

Comments

@ndevenish
Copy link
Contributor

Running tests without XDS present give:

        for step in ["XYCORR", "INIT", "COLSPOT", "IDXREF"]:
>           lastrecord = open("%s.LP" % step).readlines()[-1]
E           FileNotFoundError: [Errno 2] No such file or directory: 'XYCORR.LP'

fast_dp/autoindex.py:106: FileNotFoundError

This is because run_job doesn't check and provides no way to tell if the process actually ran, so autoindex just carries on as if it's worked:

fast_dp/fast_dp/autoindex.py

Line 98 in 4ea4775

log = run_job("xds_par")

ndevenish added a commit that referenced this issue Sep 28, 2023
@ndevenish
Update run_job.run_job
dcc7a5f 
This now uses subprocess.run, which takes some of the
complexity away of properly running subprocesses. Also,
raise an exception if this fails or if the executable
can not be found.

Fixes #55.
@ndevenish ndevenish linked a pull request Sep 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update run_job.run_job DiamondLightSource/fast_dp
1 participant
@ndevenish