ecc_correct is slower than it needs to be

[ohsix]

from init_bch:

• This initialization can take some time, as lookup tables are built for fast
• encoding/decoding; make sure not to call this function from a time critical
• path. Usually, init_bch() should be called on module/driver init and
• free_bch() should be called to release memory on exit.

ecc_correct is calling init_bch for every page

[virtualabs]

Seems you're right. I fixed the code in the last commit on master branch, could you give it a try ?

[ohsix]

it's much faster but i can't actually tell if it is working properly, have a weird image

on the mx53 the fcb kobs generates doesn't have the ecc information in it https://github.com/NXPmicro/imx-kobs/blob/c50b0a001d506a8c39c206b26ec24e71fcf2afb6/src/mtd.c#L3489

it also disables the bbm remapping in the later version https://github.com/NXPmicro/imx-kobs/blob/c50b0a001d506a8c39c206b26ec24e71fcf2afb6/src/plat_boot_config.c#L75

i hacked some stuff together but the verification i'm doing doesn't think the result is usable (extracting the filesystem fails, for example)

could give more specifics via email

thanks!