tests

Author: DomCR

src/ACadSharp.Tests/Objects/GroupTests.cs

@@ -0,0 +1,52 @@
+using ACadSharp.Entities;
+using ACadSharp.Objects;
+using System;
+using Xunit;
+
+namespace ACadSharp.Tests.Objects
+{
+	public class GroupTests : NonGraphicalObjectTests<Group>
+	{
+		[Fact]
+		public void AddTest()
+		{
+			CadDocument doc = new CadDocument();
+			Line l = new Line();
+			var group = new Group();
+
+			group.Add(l);
+
+			Assert.Contains(group, l.Reactors);
+			Assert.Throws<InvalidOperationException>(() => doc.Groups.Add(group));
+
+			group.Clear();
+
+			Assert.DoesNotContain(group, l.Reactors);
+
+			doc.Groups.Add(group);
+			Assert.Contains(group, doc.Groups);
+
+			Assert.Throws<InvalidOperationException>(() => group.Add(l));
+
+			doc.Entities.Add(l);
+			group.Add(l);
+
+			Assert.Contains(l, group.Entities);
+		}
+
+		[Fact]
+		public void IsUnnamedTest()
+		{
+			var group = new Group();
+
+			Assert.True(group.IsUnnamed);
+			group.Name = null;
+			Assert.True(group.IsUnnamed);
+			group.Name = " ";
+			Assert.True(group.IsUnnamed);
+
+			group.Name = "my_group";
+			Assert.False(group.IsUnnamed);
+		}
+	}
+}

src/ACadSharp/CadObject.cs

@@ -59,14 +59,7 @@ public IEnumerable<CadObject> Reactors
 		{
 			get
 			{
-				if (this.Document == null)
-				{
-					return Enumerable.Empty<CadObject>();
-				}
-				else
-				{
-					return this._reactors;
-				}
+				return this._reactors;
 			}
 		}
 

src/ACadSharp/Objects/Collections/GroupCollection.cs

@@ -1,4 +1,5 @@
 using ACadSharp.Entities;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
@@ -15,6 +16,14 @@ public GroupCollection(CadDictionary dictionary) : base(dictionary)
 		/// <inheritdoc/>
 		public override void Add(Group entry)
 		{
+			foreach (var e in entry.Entities)
+			{
+				if (e.Document != this._dictionary.Document)
+				{
+					throw new InvalidOperationException("Entities in a group must be in the same document as the group being added.");
+				}
+			}
+
 			if (entry.IsUnnamed)
 			{
 				int next = 0;

src/ACadSharp/Objects/Group.cs

@@ -39,7 +39,7 @@ public class Group : NonGraphicalObject
 		/// The name for an unnamed group will be managed by the <see cref="GroupCollection"/>.
 		/// </remarks>
 		[DxfCodeValue(70)]
-		public bool IsUnnamed { get { return !this.Name.IsNullOrWhiteSpace() && this.Name.StartsWith("*"); } }
+		public bool IsUnnamed { get { return this.Name.IsNullOrWhiteSpace() || this.Name.StartsWith("*"); } }
 
 		/// <inheritdoc/>
 		public override string ObjectName => DxfFileToken.TableGroup;
@@ -95,6 +95,29 @@ public void AddRange(IEnumerable<Entity> entities)
 			}
 		}
 
+		/// <summary>
+		/// Removes all entities in the group.
+		/// </summary>
+		public void Clear()
+		{
+			foreach (var e in this._entities)
+			{
+				e.RemoveReactor(this);
+			}
+
+			this._entities.Clear();
+		}
+
+		/// <summary>
+		/// Removes the entity from the group.
+		/// </summary>
+		/// <param name="entity"></param>
+		public bool Remove(Entity entity)
+		{
+			entity.RemoveReactor(this);
+			return this._entities.Remove(entity);
+		}
+
 		/// <inheritdoc/>
 		public override CadObject Clone()
 		{

src/CodeMaid.config

@@ -82,6 +82,10 @@
                 <value>False</value>
             </setting>
             <setting name="Cleaning_InsertExplicitAccessModifiersOnProperties"
+                serializeAs="String">
+                <value>False</value>
+            </setting>
+            <setting name="Cleaning_InsertBlankSpaceBeforeSelfClosingAngleBrackets"
                 serializeAs="String">
                 <value>True</value>
             </setting>