Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1402 Should not apply to file-scoped types #3803

Open
RenderMichael opened this issue Feb 12, 2024 · 4 comments · May be fixed by #3879
Open

SA1402 Should not apply to file-scoped types #3803

RenderMichael opened this issue Feb 12, 2024 · 4 comments · May be fixed by #3879

Comments

@RenderMichael
Copy link

The following code should not give a warning

public sealed class C
{
}

file static class CHelpers
{
}
@bjornhellander
Copy link
Contributor

Seems like a reasonable request to me, since this situation is why the file modifier was added

6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Jul 31, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
b59544c
@6bee
Copy link

6bee commented Jul 31, 2024

Please merge PR #3879 to resolve this issue.

6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 3, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
4e322a4
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 26, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
694574c
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 30, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
1cbb532
@6bee 6bee linked a pull request Aug 30, 2024 that will close this issue
Open
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 30, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
a87e793
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 30, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
c4b4ac9
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 30, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
06ec4fb
6bee added a commit to 6bee/StyleCopAnalyzers that referenced this issue Aug 31, 2024
@6bee
Exempt file-local types from SA1402 [resolves DotNetAnalyzers#3803]
9bff5a2
@6bee
Copy link

6bee commented Feb 4, 2025

There has been a ready-to-merge PR to resolve this issue, waiting for six month, that has not event been looked at. If maintenance for this project/repo has been abandoned, please mention it in the readme so people no longer need bother.

@julealgon
Copy link

@sharwell can you provide a position on this? Is there a reason these small changes are kept waiting for months without being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exempt file-local types from SA1402 [resolves #3803] 6bee/StyleCopAnalyzers
4 participants
@julealgon @bjornhellander @RenderMichael @6bee