[BUG] Typograhy.Text component use ReactDom.render promotes console error #2699
Comments
15 tasks
|
The use of ReactDOM.render in typography can be removed。 |
|
@DaiQiangReal See how to modify the use of ReactDOM.render in Modal, Toast, and Notification? |
|
|
目前暂定的解决方案是在同一个包里发两个入口文件的 semi ，待后续进行 react19 改造的时候再详细讨论
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Which Component
Typograhy.Text
Semi Version
2.73.0
Current Behavior
I'm using React 18, when use Text component with fixed width, it will log an annoying error: Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot
Expected Behavior
No error
Steps To Reproduce
I think the source code explains everything, check typography/util.es,
it use
ReactDOM.render(/*#__PURE__*/React.createElement(React.Fragment, null), ellipsisContainer);to calculate if width are exceed limit, I think it could be done without using ReactDOM.render here.ReproducibleCode
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: