Code cleanup. Make RecursiveFillW.. internal. Make GetOrphanedSerializablesAndClearHistoricalTraceData return List, add fast lookup.

Author: bendikberg

src/DynamoCore/Graph/Workspaces/HomeWorkspaceModel.cs

@@ -880,7 +880,7 @@ private void OnPreviewGraphCompleted(AsyncTask asyncTask)
         /// trace data but do not exist in the current CallSite data.
         /// </summary>
         /// <returns></returns>
-        internal IList<string> GetOrphanedSerializablesAndClearHistoricalTraceData()
+        internal List<string> GetOrphanedSerializablesAndClearHistoricalTraceData()
         {
             var orphans = new List<string>();
 
@@ -891,11 +891,12 @@ internal IList<string> GetOrphanedSerializablesAndClearHistoricalTraceData()
             // then add the serializables for that guid to the list of
             // orphans.
 
+            var nodeLookup = Nodes.Select(n => n.GUID).ToHashSet();
             foreach (var nodeData in historicalTraceData)
             {
                 var nodeGuid = nodeData.Key;
 
-                if (Nodes.All(n => n.GUID != nodeGuid))
+                if (!nodeLookup.Contains(nodeGuid))
                 {
                     orphans.AddRange(nodeData.Value.SelectMany(CallSite.GetAllSerializablesFromSingleRunTraceData));
                 }

src/DynamoCore/Models/DynamoModel.cs

@@ -1265,17 +1265,22 @@ private void EngineController_TraceReconcliationComplete(TraceReconciliationEven
             foreach (var maybeWs in Workspaces)
             {
                 foreach (var node in maybeWs.Nodes)
+                {
                     nodeToWorkspaceMap[node.GUID] = maybeWs;
+                }
 
-                var ws = maybeWs as HomeWorkspaceModel;
-                if (ws == null)
+                if (maybeWs is not HomeWorkspaceModel ws)
+                {
                     continue;
+                }
 
                 // Get the orphaned serializables to this workspace
-                var wsOrphans = (List<string>)ws.GetOrphanedSerializablesAndClearHistoricalTraceData();
+                var wsOrphans = ws.GetOrphanedSerializablesAndClearHistoricalTraceData();
 
                 if (!wsOrphans.Any())
+                {
                     continue;
+                }
 
                 if (workspaceOrphanMap.TryGetValue(ws.Guid, out var workspaceOrphans))
                 {
@@ -1296,15 +1301,9 @@ private void EngineController_TraceReconcliationComplete(TraceReconciliationEven
                 // TODO: MAGN-7314
                 // Find the owning workspace for a node.
                 if (!nodeToWorkspaceMap.TryGetValue(nodeGuid, out var nodeSpace))
+                {
                     continue;
-
-                //var nodeSpace =
-                //    Workspaces.FirstOrDefault(
-                //        ws =>
-                //            ws.Nodes.FirstOrDefault(n => n.GUID == nodeGuid)
-                //                != null);
-
-                //if (nodeSpace == null) continue;
+                }
 
                 // Add the node's orphaned serializables to the workspace
                 // orphan map.

src/Engine/ProtoCore/Lang/CallSite.cs

@@ -159,15 +159,19 @@ public List<string> RecursiveGetNestedData()
                 return ret;
             }
 
-            public void RecursiveFillWithNestedData(List<string> listToFill)
+            internal void RecursiveFillWithNestedData(List<string> listToFill)
             {
                 if (HasData)
+                {
                     listToFill.Add(Data);
+                }
 
                 if (HasNestedData)
                 {
                     foreach (SingleRunTraceData srtd in NestedData)
+                    {
                         srtd.RecursiveFillWithNestedData(listToFill);
+                    }
                 }
             }
         }
@@ -475,8 +479,10 @@ private static string CompressSerializedTraceData(string json)
         /// </summary>
         public IList<string> GetOrphanedSerializables()
         {
-            if (beforeFirstRunSerializables.Count == 0)
+            if (!beforeFirstRunSerializables.Any())
+            {
                 return new List<string>();
+            }
 
             var currentSerializables = traceData.SelectMany(td => td.RecursiveGetNestedData()).ToHashSet();
             var result = beforeFirstRunSerializables.Where(hs => !currentSerializables.Contains(hs)).ToList();