DYN-10096: On package install engine_version checks are suppressed if compatibility_matrix check passes#17173
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10096
ivaylo-matov
changed the title
…n-checks-are-suppressed-if-compatibility_matrix-check-pass
jasonstratton
left a comment
jasonstratton
left a comment
There was a problem hiding this comment.
Address the two comments and I think it's good. ... Just let me know when you're done in order to merge.
| try | ||
| // If the compatibility matrix already indicates compatibility, skip the engine_version heuristic. | ||
| // Only perform engine_version based warnings when compatibility is not explicitly true. | ||
| if (compatible == false) |
There was a problem hiding this comment.
Should this be if (compatible != true)? ... There are actually 3 states, true, false and null
|
|
||
| [Test] | ||
| [Description("If the package compatibility matrix explicitly marks the package as compatible, do NOT show engine_version newer/older warnings even when engine_version differs.")] | ||
| public void PackageManagerDoesNotShowEngineVersionWarningWhenCompatibilityMatrixIsCompatible() |
There was a problem hiding this comment.
Tests the happy path, please add a test for the null case (no matrix → warning should still appear)
There was a problem hiding this comment.
PackageManagerDoesNotShowEngineVersionWarningWhenCompatibilityMatrixIsCompatible now added to test the null case
|
Thanks for the review, @jasonstratton ! I've addressed both comments, the PR should be ready to merge. |
2 participants
Purpose
This PR fixes DYN-10069, where Clockwork installation on Dynamo 3.6.1 incorrectly triggers engine version warnings despite valid compatibility.
Root cause is in
PackageManagerClientViewModel.ExecutePackageDownload(), which evaluates bothcompatibility_matrixand publishedengine_version. The engine version check can override valid compatibility results.Fix:
compatibility_matrixthe primary compatibility sourceengine_versionwhen compatibility is unknown or incompatiblecompatibility_matrixreports compatibilityDeclarations
Check these if you believe they are true
Release Notes
Fixes incorrect package compatibility warnings during installation when packages are marked compatible via the compatibility matrix.
Reviewers
@DynamoDS/eidos
@jasonstratton
FYIs
@johnpierson
@dnenov