Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tallysheet reports #842

Open
8 of 10 tasks
umayangag opened this issue Dec 2, 2020 · 2 comments
Open
8 of 10 tasks

Fix tallysheet reports #842

umayangag opened this issue Dec 2, 2020 · 2 comments
Assignees
@dinukadesilva @umayangag
Labels
back-end bug Something isn't working

Comments

@umayangag
Copy link
Collaborator

umayangag commented Dec 2, 2020 •
edited
Loading

  • Polling Division Results
  • Polling Division Results (Postal)
  • PCE-R2
  • PCE-42
  • Provincial Vote Results
  • Candidates List
  • Bonus Seat Allocation 1
  • Bonus Seat Allocation 2
  • Seat Allocation 1
  • Seat Allocation 2
@umayangag umayangag self-assigned this Dec 2, 2020
@umayangag umayangag added back-end bug Something isn't working labels Dec 2, 2020
@dinukadesilva
Copy link
Member

Not all of the tally sheet extensions are mapped correctly and the system doesn't know those have been defined. Consequently, the aggregations, etc are not working.

eg: Polling Division Results is giving an empty view because it hasn't been mapped and the system considers that as a data entry form.

https://github.com/ECLK/results-tabulation/blob/master/results-tabulation-api/ext/ExtendedElection/ExtendedElectionProvincialCouncilElection2021/ExtendedFunctions/get_extended_tally_sheet_class.py#L47

umayangag added a commit to umayangag/results-tabulation that referenced this issue Dec 7, 2020
@umayangag
fix issue ECLK#842
bd3e602
umayangag added a commit to umayangag/results-tabulation that referenced this issue Dec 7, 2020
@umayangag
fix issue ECLK#842
766b263
dinukadesilva added a commit to dinukadesilva/results-tabulation that referenced this issue Dec 8, 2020
@dinukadesilva
ECLKgh-842: Fix the derivative tally sheet validations in PEC-42
ae7cbe9
umayangag added a commit that referenced this issue Dec 9, 2020
@umayangag
Merge pull request #845 from dinukadesilva/gh-842-fix-pec-42-validations
8643b38 
gh-842: Fix the derivative tally sheet validations in PEC-42
@umayangag
Copy link
Collaborator Author

provincial vote results give an error in sorting.
https://github.com/ECLK/results-tabulation/blob/master/results-tabulation-api/ext/ExtendedTallySheet/__init__.py#L877

dinukadesilva added a commit to dinukadesilva/results-tabulation that referenced this issue Dec 15, 2020
@dinukadesilva
ECLKgh-842: Adding the missing required numValue column to the cand…
7626174 
…idates summary sheets
umayangag added a commit that referenced this issue Dec 16, 2020
@umayangag
Merge pull request #848 from dinukadesilva/gh-842-fix-pce-pc-cd-candi…
8fefacc 
…dates-list

gh-842: Adding the missing required `numValue` column to the candidates summary sheets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dinukadesilva dinukadesilva

@umayangag umayangag

Labels
back-end bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dinukadesilva @umayangag