Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complexity of vpr_autoid_read() #55

Open
EOGrady21 opened this issue Oct 13, 2023 · 0 comments
Open

complexity of vpr_autoid_read() #55

EOGrady21 opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@EOGrady21
Copy link
Owner

Copliot brought to my attention that vpr_autoid_read() has a very high cyclomatic complexity of 23

It should be reduced by removing some of the conditional (if) statements. I think this issue is mainly due to the inclusion of aid and aidmeas data within the same function. Now that we have moved away from Visual Plankton we could split this into two functions, one to read measurement data (from ImageJ) and one to read aid files. Really the measurement data workflow has been separated from vprr in practicality. Maybe it could be removed all together.

@kevinsorochan thoughts?
@EOGrady21 EOGrady21 added enhancement New feature or request help wanted Extra attention is needed labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EOGrady21