Updating WPCS & PHPCompatibility sniffs.

Author: davelavoie

README.md

@@ -3,7 +3,7 @@ c9.ide.language.php.wordpress
 
 __Name__ : WordPress Coding Standards Linter for Cloud9 
 
-__Current Version__: 0.0.1 (alpha)
+__Current Version__: 0.0.2a
 
 __Author__ : [EP4](https://ep4.com)
 
@@ -72,4 +72,16 @@ Ressources
 * PHP CodeSniffer : [GitHub repo](https://github.com/squizlabs/PHP_CodeSniffer) & [Wiki](https://github.com/squizlabs/PHP_CodeSniffer/wiki)
 * WordPress Coding Standards : [GitHub Repo](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards), [Wiki](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki) & [Whitelisting code which flags errors](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Whitelisting-code-which-flags-errors)
 * PHPCompatibility : [GitHub Repo](https://github.com/wimg/PHPCompatibility)
-* Cloud9 : [SDK](https://cloud9-sdk.readme.io/) & [API](https://apidoc.c9.io)
+* Cloud9 : [SDK](https://cloud9-sdk.readme.io/) & [API](https://apidoc.c9.io)
+
+Changelog
+---------
+
+### 0.0.2a - 2017-02-13
+
+* Updating WP Coding Standards with the latest release as of 2017-02-10.
+* Updading PHPCompabitity with the latest release as of 2017-02-06
+
+### 0.0.1 (alpha) - 2017-02-10
+
+Initial release.

package.json

@@ -1,7 +1,7 @@
 {
   "name": "phpcs.wpcs",
   "description": "Displays warnings in the IDE with the help of PHP CodeSniffer configured with WordPress Coding Standards and PHPCompatibility rules.",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "author": "EP4",
   "contributors": [
     {

server/phpcs/rules/PHPCompatibility/Sniffs/PHP/ForbiddenCallTimePassByReferenceSniff.php

@@ -179,6 +179,24 @@ protected function isCallTimePassByReferenceParam(PHP_CodeSniffer_File $phpcsFil
                 case T_CLOSE_PARENTHESIS:
                     break;
 
+                // Prevent false positive on assign by reference and compare with reference
+                // with function call parameters.
+                case T_EQUAL:
+                case T_AND_EQUAL:
+                case T_OR_EQUAL:
+                case T_CONCAT_EQUAL:
+                case T_DIV_EQUAL:
+                case T_MINUS_EQUAL:
+                case T_MOD_EQUAL:
+                case T_MUL_EQUAL:
+                case T_PLUS_EQUAL:
+                case T_XOR_EQUAL:
+                case T_SL_EQUAL:
+                case T_SR_EQUAL:
+                case T_IS_EQUAL:
+                case T_IS_IDENTICAL:
+                    break;
+
                 // Unfortunately the tokenizer fails to recognize global constants,
                 // class-constants and -attributes. Any of these are returned is
                 // treated as T_STRING.
@@ -200,6 +218,11 @@ protected function isCallTimePassByReferenceParam(PHP_CodeSniffer_File $phpcsFil
                     // If not a class constant: fall through.
 
                 default:
+                    // Deal with T_POW_EQUAL which doesn't exist in PHPCS 1.x
+                    if (defined('T_POW_EQUAL') && $tokens[$tokenBefore]['type'] === 'T_POW_EQUAL') {
+                        break;
+                    }
+
                     // The found T_BITWISE_AND represents a pass-by-reference.
                     return true;
             }

server/phpcs/rules/PHPCompatibility/Sniffs/PHP/ForbiddenNamesAsDeclaredSniff.php

@@ -87,6 +87,10 @@ public function register()
      */
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
+        if ($this->supportsAbove('7.0') === false) {
+            return;
+        }
+
         $tokens         = $phpcsFile->getTokens();
         $tokenCode      = $tokens[$stackPtr]['code'];
         $tokenContentLc = strtolower($tokens[$stackPtr]['content']);

server/phpcs/rules/PHPCompatibility/Tests/BaseClass/FunctionsTest.php

@@ -27,11 +27,22 @@ class BaseClass_FunctionsTest extends PHPUnit_Framework_TestCase
     protected $helperClass;
 
 
+    /**
+     * Set up fixtures for this unit test.
+     *
+     * @return void
+     */
     public static function setUpBeforeClass()
     {
         require_once dirname(__FILE__) . '/TestHelperPHPCompatibility.php';
+        parent::setUpBeforeClass();
     }
 
+    /**
+     * Sets up this unit test.
+     *
+     * @return void
+     */
     protected function setUp()
     {
         parent::setUp();

server/phpcs/rules/PHPCompatibility/Tests/BaseClass/MethodTestFrame.php

@@ -45,11 +45,22 @@ abstract class BaseClass_MethodTestFrame extends PHPUnit_Framework_TestCase
     protected $helperClass;
 
 
+    /**
+     * Set up fixtures for this unit test.
+     *
+     * @return void
+     */
     public static function setUpBeforeClass()
     {
         require_once dirname(__FILE__) . '/TestHelperPHPCompatibility.php';
+        parent::setUpBeforeClass();
     }
 
+    /**
+     * Sets up this unit test.
+     *
+     * @return void
+     */
     protected function setUp()
     {
         parent::setUp();

server/phpcs/rules/PHPCompatibility/Tests/BaseSniffTest.php

@@ -39,6 +39,7 @@ class BaseSniffTest extends PHPUnit_Framework_TestCase
     public static function setUpBeforeClass()
     {
         self::$sniffFiles = array();
+        parent::setUpBeforeClass();
     }
 
     /**
@@ -59,6 +60,8 @@ protected function setUp()
 
         self::$phpcs->process(array(), dirname( __FILE__ ) . '/../');
         self::$phpcs->setIgnorePatterns(array());
+
+        parent::setUp();
     }
 
     /**

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/ForbiddenBreakContinueVariableArgumentsSniffTest.php

@@ -36,11 +36,11 @@ class ForbiddenBreakContinueVariableArgumentsSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for this unit test.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/ForbiddenCallTimePassByReferenceSniffTest.php

@@ -30,11 +30,11 @@ class ForbiddenCallTimePassByReferenceSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for this unit test.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 
@@ -79,6 +79,7 @@ public function dataForbiddenCallTimePassByReference() {
             array(44), // Bad: call time pass by reference.
             array(45), // Bad: call time pass by reference.
             array(49), // Bad: multiple call time pass by reference.
+            array(71), // Bad: call time pass by reference.
         );
     }
 
@@ -122,6 +123,26 @@ public function dataNoViolation()
 
             array(51), // OK: No variables.
             array(53), // OK: Outside scope of this sniff.
+
+            // Assign by reference within function call.
+            array(56),
+            array(57),
+            array(58),
+            array(59),
+            array(60),
+            array(61),
+            array(62),
+            array(63),
+            array(64),
+            array(65),
+            array(66),
+            array(67),
+            array(68),
+            array(69),
+
+            // Comparison with reference.
+            array(74),
+            array(75),
         );
     }
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/InternalInterfacesSniffTest.php

@@ -28,11 +28,11 @@ class InternalInterfacesSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for this unit test.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/NewExecutionDirectivesSniffTest.php

@@ -30,11 +30,11 @@ class NewExecutionDirectivesSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for some of these unit tests.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/NewMagicMethodsSniffTest.php

@@ -30,13 +30,17 @@ class NewMagicMethodsSniffTest extends BaseSniffTest
 
     /**
      * Set up skip condition.
+     *
+     * @return void
      */
     public static function setUpBeforeClass()
     {
         // When using PHPCS 1.x combined with PHP 5.3 or lower, traits are not recognized.
         if (version_compare(PHP_CodeSniffer::VERSION, '2.0', '<') && version_compare(phpversion(), '5.4', '<')) {
             self::$recognizesTraits = false;
         }
+
+        parent::setUpBeforeClass();
     }
 
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/NewScalarReturnTypeDeclarationsSniffTest.php

@@ -23,7 +23,9 @@ class NewScalarReturnTypeDeclarationsSniffTest extends BaseSniffTest
     const TEST_FILE = 'sniff-examples/new_scalar_return_type_declarations.php';
 
     /**
-     * Set up: skip these tests if the PHPCS version isn't high enough.
+     * Skip the test(s) for low PHPCS versions.
+     *
+     * @return void
      */
     protected function setUp()
     {

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/NonStaticMagicMethodsSniffTest.php

@@ -30,13 +30,17 @@ class NonStaticMagicMethodsSniffTest extends BaseSniffTest
 
     /**
      * Set up skip condition.
+     *
+     * @return void
      */
     public static function setUpBeforeClass()
     {
         // When using PHPCS 1.x combined with PHP 5.3 or lower, traits are not recognized.
         if (version_compare(PHP_CodeSniffer::VERSION, '2.0', '<') && version_compare(phpversion(), '5.4', '<')) {
             self::$recognizesTraits = false;
         }
+
+        parent::setUpBeforeClass();
     }
 
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/RemovedAlternativePHPTagsUnitTest.php

@@ -31,12 +31,16 @@ class RemovedAlternativePHPTagsSniffTest extends BaseSniffTest
 
     /**
      * Set up skip condition.
+     *
+     * @return void
      */
     public static function setUpBeforeClass()
     {
         if (version_compare(phpversion(), '7.0', '<')) {
             self::$aspTags = (boolean) ini_get('asp_tags');
         }
+
+        parent::setUpBeforeClass();
     }
 
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/RemovedExtensionsSniffTest.php

@@ -31,11 +31,11 @@ class RemovedExtensionsSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for some of these unit tests.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 

server/phpcs/rules/PHPCompatibility/Tests/Sniffs/PHP/ValidIntegersSniffTest.php

@@ -30,11 +30,11 @@ class ValidIntegersSniffTest extends BaseSniffTest
     protected $_sniffFile;
 
     /**
-     * setUp
+     * Set up the test file for some of these unit tests.
      *
      * @return void
      */
-    public function setUp()
+    protected function setUp()
     {
         parent::setUp();
 

server/phpcs/rules/PHPCompatibility/Tests/sniff-examples/call_time_pass_by_reference.php

@@ -51,3 +51,25 @@ public function bar($arg)
 bcd(10, true, MYCONST); // OK: does not contain variables.
 
 cde((&$abc)); // OK: outside of the scope of this sniff - will result in parse error.
+
+// Issue https://github.com/wimg/PHPCompatibility/issues/68
+$attr  = $this->doExtraAttributes("h$level", $dummy =& $matches[3]); // OK: assign by reference.
+if (!is_null($done = &$this->cacheKey('autoPurgeCache'))) {} // OK: assign by reference.
+def( $dummy .= &$b );
+def( $dummy += &$b );
+def( $dummy -= &$b );
+def( $dummy *= &$b );
+def( $dummy /= &$b );
+def( $dummy %= &$b );
+def( $dummy **= &$b );
+def( $dummy &= &$b );
+def( $dummy |= &$b );
+def( $dummy ^= &$b );
+def( $dummy <<= &$b );
+def( $dummy >>= &$b );
+
+def( &$dummy .= $b ); // Bad: pass by reference.
+
+// Ok: Comparisons passed as function parameter.
+efg( true == &$b );
+efg( true === &$b );