Merge pull request #1843 from EPPlusSoftware/bug/issue1839

Fixes issue #1839.

Author: AdrianEPPlus

src/EPPlus/ConditionalFormatting/ExcelConditionalFormattingIconSetBase.cs

@@ -148,7 +148,7 @@ internal void ReadIcon(ExcelConditionalFormattingIconDataBarValue icon, XmlReade
             {
                 var iconValue = xr.GetAttribute("val");
 
-                if(ConvertUtil.TryParseNumericString(iconValue, out double numValue))
+                if(ConvertUtil.TryParseNumericString(iconValue, out double numValue, CultureInfo.InvariantCulture))
                 {
                     icon.Value = numValue;
                 }

src/EPPlus/Drawing/Vml/VmlConvertUtil.cs

@@ -1,6 +1,7 @@
 using OfficeOpenXml.Drawing.Controls;
 using OfficeOpenXml.Utils;
 using System;
+using System.Globalization;
 
 namespace OfficeOpenXml.Drawing.Vml
 {
@@ -14,17 +15,17 @@ internal static double GetOpacityFromStringVml(string v)
             }
             if (v.EndsWith("f", StringComparison.OrdinalIgnoreCase))
             {
-                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d);
+                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d, CultureInfo.InvariantCulture);
                 return (d / 0x10000) * 100;
             }
             else if (v.EndsWith("%"))
             {
-                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d);
+                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d, CultureInfo.InvariantCulture);
                 return d;
             }
             else
             {
-                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d);
+                ConvertUtil.TryParseNumericString(v.Substring(0, v.Length - 1), out double d, CultureInfo.InvariantCulture);
                 return d * 100;
             }
         }

src/EPPlus/ExcelWorksheet.cs

@@ -3658,6 +3658,7 @@ internal void SetStyleInner(int row, int col, int styleId)
             {
                 var v = GetCoreValueInner(row, col);
                 v._value = Workbook.Styles.RoundValueFromNumberFormat(v._value, styleId);
+                v._styleId = styleId;
                 _values.SetValue(row, col, v);
             }
         }

src/EPPlus/Filter/ExcelFilterItem.cs

@@ -34,7 +34,7 @@ public ExcelFilterValueItem(string value)
         {
             Value = value;
             Utils.ConvertUtil.TryParseNumericString(value, out _valueDouble, CultureInfo.InvariantCulture);
-            }
+        }
         /// <summary>
         /// A value to be filtered.
         /// </summary>

src/EPPlus/Style/RichText/ExcelRichText.cs

@@ -355,7 +355,7 @@ internal void ReadrPr(XmlReader xr)
                         VerticalAlign = xr.GetAttribute("val").ToEnum<ExcelVerticalAlignmentFont>(ExcelVerticalAlignmentFont.None);
                         break;
                     case "sz":
-                        if (ConvertUtil.TryParseNumericString(xr.GetAttribute("val"), out double num))
+                        if (ConvertUtil.TryParseNumericString(xr.GetAttribute("val"), out double num, CultureInfo.InvariantCulture))
                         {
                             Size = Convert.ToSingle(num);
                         }

src/EPPlus/Table/PivotTable/ExcelPivotTableCacheField.cs

@@ -607,7 +607,7 @@ private void AddItems(EPPlusReadOnlyList<Object> items, XmlNode itemsNode, Dicti
                 }
                 else if (c.LocalName == "n")
                 {
-                    if (ConvertUtil.TryParseNumericString(c.Attributes["v"].Value, out double num))
+                    if (ConvertUtil.TryParseNumericString(c.Attributes["v"].Value, out double num, CultureInfo.InvariantCulture))
                     {
                         items.Add(num);
                     }

src/EPPlus/XmlHelper.cs

@@ -1470,7 +1470,7 @@ internal static float GetRichTextProperyFloat(XmlNode n)
         {
             if (n != null)
             {
-                if (ConvertUtil.TryParseNumericString(n.Attributes["val"].Value, out double num))
+                if (ConvertUtil.TryParseNumericString(n.Attributes["val"].Value, out double num, CultureInfo.InvariantCulture))
                 {
                    return Convert.ToSingle(num);
                 }

src/EPPlusTest/Issues/StylingIssues.cs

@@ -362,7 +362,13 @@ public void s1808_2()
             //p.Workbook.Worksheets.Add("Copied Sheet", ws);
             SaveAndCleanup(p);
         }
-
+        [TestMethod]
+        public void i1839()
+        {
+            using var p = OpenTemplatePackage("i1839.xlsx");
+            Assert.AreEqual(288, p.Workbook.Worksheets[0].Cells["E31"].StyleID);
+            SaveWorkbook("i1839-saved.xlsx", p);
+        }
         public class TestData
         {
             public int Id { get; set; }