Skip to content

Commit 09bb504

Browse files
committed
add unit testing section to walkthrough
1 parent 722710b commit 09bb504

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

docs/conversion/walkthrough.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,9 +682,13 @@ Bug gets extremely lucky (or maybe he's just really skilled) and there are no di
682682
## 9 - Bring back into CAM
683683
Bug moves the CCPP-ized version of lunar_tides.F90 into the CAM source tree, updates `configure`, and runs CAM. He confirms that it runs and answers haven't changed.
684684

685-
Bug commits his changes to his fork/branch of the three repos: CAM, CAM-SIMA, atmospheric_physics.
685+
Bug commits his changes to his fork/branch of the three repos: CAM, CAM-SIMA, atmospheric_physics.
686686

687-
- He opens a PR into atmospheric_physics (target: `development` branch), goes through the review process, adds a Changelog entry, and then commits the PR when approvals are received. He then makes a tag (incrementing the minor version).
687+
### Unit testing
688+
Bug adds PfUnit tests for his newly-created scheme per the [atmospheric_physics development workflow](../atmospheric_physics/development_workflow.md#5-unit-testing).
689+
690+
### Pull Requests
691+
- He opens a PR into atmospheric_physics (target: `development` branch), goes through the review process, updates the NamesNotInDictionary.txt file, and then commits the PR when approvals are received. He then opens a PR from `development` to `main` and makes a tag (incrementing the minor version) when that is merged.
688692
- Once he has a tag, he opens PRs into CAM (target: `cam_development` branch) and CAM-SIMA (target: `development` branch) with the updated tag in `.gitmodules` (and code changes needed). When approvals are in and he gets the go-ahead to make a tag, he follows the procedures to make a CAM or CAM-SIMA tag.
689693
- Once all tags are made, he checks off "lunar tides" as completed in the [spreadsheet](https://docs.google.com/spreadsheets/d/1_1TTpnejam5jfrDqAORCCZtfkNhMRcu7cul37YTr_WM/edit#gid=0).
690694

0 commit comments

Comments
 (0)