FATES `successful_ignitions` spitfire mode does not pass lightning data

[glemieux]

Brief summary of bug

The FATES successful_ignitions option should pass lightning data to FATES, but it currently sets fates_fire_no_data_type as the fire method.

General bug information

CTSM version you are using: ctsm5.4.038

Does this bug cause significantly incorrect results in the model's science? Yes

Details of bug

This was discovered while trying to answer NGEET/fates#1562. During discussion with the author, it was noted that the current version sets the no data type for the fates_fire_data_method:

CTSM/src/biogeochem/FATESFireFactoryMod.F90

Lines 89 to 90 in e1f563b

	case (successful_ignitions)
	allocate(fates_fire_no_data_type :: fates_fire_data_method)

The version the author is using (ctsm5.3.012), is inclusive of the successful_ignitions option:

CTSM/src/biogeochem/FATESFireFactoryMod.F90

Lines 65 to 66 in ab466d6

	case (lightning_from_data:anthro_suppression)
	allocate(fates_fire_data_type :: fates_fire_data_method)

I believe the code should be updated to reinstate successful_ignitions as an option.

Note that this namelist option does not have a test, in part, due to #1266.

Important details of your setup / configuration so we can reproduce the bug

fates_spitfire_mode = 3

Important output or errors that show the problem

This hasn't been tested yet to determine what the output response is.