Merge pull request #30 from ESP32Async/issues/ws-cleanup

fix(ws): break loop after erasing client
ESP32Async · Jan 28, 2025 · 9bdefb8 · 9bdefb8
2 parents 7be1742 + 180b850
commit 9bdefb8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/AsyncWebSocket.cpp b/src/AsyncWebSocket.cpp
@@ -916,11 +916,10 @@ void AsyncWebSocket::cleanupClients(uint16_t maxClients) {
     _clients.front().close();
   }
 
-  for (auto iter = std::begin(_clients); iter != std::end(_clients);) {
-    if (iter->shouldBeDeleted()) {
-      iter = _clients.erase(iter);
-    } else {
-      iter++;
+  for (auto i = _clients.begin(); i != _clients.end(); ++i) {
+    if (i->shouldBeDeleted()) {
+      _clients.erase(i);
+      break;
     }
   }
 }