-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM17 verifier gadget for libsnark #3
Open
PossiblyHarry
wants to merge
15
commits into
ey
Choose a base branch
from
gm17-verifier-gadget
base: ey
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accepts a pb_variable_array instead.
Closed
Note, I changed the submodule URLs in .gitmodules which may cause problems. - url = [email protected]:EYBlockchain/zk-swap-libff.git
+ url = git://github.com:EYBlockchain/zk-swap-libff.git
- url = https://github.com/scipr-lab/libfqfft.git
+ url = git://github.com/EYBlockchain/zk-swap-libfqfft.git I need an access token with 2-fa enabled account to commit to HTTPs urls, so switched to git, but github actions cannot checkout the public repo using git:// urls, so will need to switch back to https://? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
Fixes: #4
This implements the GM17 verifier and G2 point addition gadgets, with support for mnt[46]753
It is a branch off of #1
Constraints, mnt4, verifies mnt6:
number of constraints for verifier: 78379 (verifier is implemented in mnt4 constraints and verifies mnt6 proofs))
Constraints, mnt6 verifies mnt4:
number of constraints for verifier: 45039 (verifier is implemented in mnt6 constraints and verifies mnt4 proofs))