fix: Correctly reference status check sources

Author: jrgns

lib/proxes/controllers/status.rb

@@ -34,7 +34,7 @@ class Status < Ditty::ApplicationController
         checks.unshift(
           text: 'Cluster Reachable',
           passed: true,
-          value: ProxES::StatusCheck.source_result('health')['cluster_name']['cluster_name']
+          value: ProxES::StatusCheck.source_result['health']['cluster_name']['cluster_name']
         )
       rescue Faraday::Error => e
         checks << { text: 'Cluster Reachable', passed: false, value: e.message }

lib/proxes/models/status_check.rb

@@ -31,7 +31,7 @@ def passed?
     end
 
     def source_result
-      self.class.source_result(source)
+      self.class.source_result[source]
     end
 
     def children; end
@@ -53,12 +53,12 @@ def es_client
         @@es_client
       end
 
-      def source_result(source)
+      def source_result
         raise 'No search client' unless es_client
 
-        @source_result ||= TimedCache.new do |h, k|
+        @@source_result ||= TimedCache.new do |h, k|
           h[k] = es_client
-          SOURCE_CALLS[source.to_sym].each do |call|
+          SOURCE_CALLS[k.to_sym].each do |call|
             h[k] = h[k].send(call)
           end
           h[k]

lib/proxes/models/status_checks/cluster_health_status_check.rb

@@ -3,7 +3,7 @@
 module ProxES
   class ClusterHealthStatusCheck < StatusCheck
     def value
-      source_result['status']['status']
+      source_result['status']
     end
 
     def check

lib/proxes/models/status_checks/cpu_status_check.rb

@@ -7,7 +7,7 @@ def value
     end
 
     def children
-      @children ||= source_result['nodes']['nodes'].values.map do |node|
+      @children ||= source_result['nodes'].values.map do |node|
         value = node['os']['cpu_percent'] || node['os']['cpu']['percent']
         [
           node['name'],

lib/proxes/models/status_checks/file_system_status_check.rb

@@ -7,7 +7,7 @@ def value
     end
 
     def children
-      @children ||= source_result['nodes']['nodes'].values.map do |node|
+      @children ||= source_result['nodes'].values.map do |node|
         next if node['attributes'] && node['attributes']['data'] == 'false'
         next if node['roles'] && node['roles'].include?('data') == false
 

lib/proxes/models/status_checks/jvm_heap_status_check.rb

@@ -7,7 +7,7 @@ def value
     end
 
     def children
-      @children ||= source_result['nodes']['nodes'].values.map do |node|
+      @children ||= source_result['nodes'].values.map do |node|
         [
           node['name'],
           node['jvm']['mem']['heap_used_percent'].to_f

lib/proxes/models/status_checks/memory_status_check.rb

@@ -8,7 +8,7 @@ def value
     end
 
     def children
-      @children ||= source_result['nodes']['nodes'].values.map do |node|
+      @children ||= source_result['nodes'].values.map do |node|
         [
           node['name'],
           node['os']['mem']['used_percent'].to_f

lib/proxes/models/status_checks/nodes_status_check.rb

@@ -17,9 +17,9 @@ def check_node(node)
     end
 
     def children
-      @children ||= source_result['nodes']['nodes'].map do |_id, node|
+      @children ||= source_result['nodes']&.map do |_id, node|
         [node['name'], 1] if check_node(node)
-      end.compact.to_h
+      end&.compact.to_h
     end
 
     def check